Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*"

Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*"

Fixes a number of cases either not caught by the automated tool or that
have recently regressed.

BUG=110610
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210048

[Ryan Sleevi, 2013-07-02 23:56:02]

TBR

[commit-bot: I haz the power, 2013-07-02 23:56:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/18308004/1

[commit-bot: I haz the power, 2013-07-03 00:05:25]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-07-03 00:07:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/18308004/1

[use derat at chromium.org, 2013-07-03 00:20:24]

Ryan, your changes look like they're getting associated with the wrong bug.
http://crbug.com/206189 is a Chrome OS testing issue from 2011.

Is this based on the "scoped_refptr<T>::operator T*" chromium-dev thread
from a year and a half ago, or something else? I'm pretty sure that I've
received review feedback within the last few months (don't remember from
whom) specifically asking me to use the implicit form when checking a
scoped_ptr for NULL-ness. A more widespread announcement may be needed,
assuming that I didn't miss it.


On Tue, Jul 2, 2013 at 4:56 PM, <rsleevi@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> TBR
>
> Description:
> Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator
> T*"
>
> Fixes a number of cases either not caught by the automated tool or that
> have recently regressed.
>
> BUG=206189
> TBR=darin
>
> Please review this at
https://codereview.chromium.**org/18308004/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/desktop_background/**desktop_background_controller.**cc
>   M cc/test/fake_picture_layer_**tiling_client.h
>   M chrome/browser/chromeos/**camera_detector.cc
>   M chrome/browser/chromeos/drive/**change_list_loader_unittest.cc
>   M chrome/browser/chromeos/drive/**change_list_processor_**unittest.cc
>   M chrome/browser/chromeos/drive/**drive_app_registry_unittest.cc
>   M chrome/browser/chromeos/drive/**drive_file_stream_reader_**unittest.cc
>   M chrome/browser/chromeos/drive/**drive_integration_service.cc
>   M chrome/browser/chromeos/drive/**drive_url_request_job_**unittest.cc
>   M chrome/browser/chromeos/drive/**file_cache.cc
>   M chrome/browser/chromeos/drive/**file_cache_unittest.cc
>   M chrome/browser/chromeos/drive/**file_system/operation_test_**base.cc
>   M chrome/browser/chromeos/drive/**file_system_proxy.cc
>   M chrome/browser/chromeos/drive/**file_system_unittest.cc
>   M chrome/browser/chromeos/drive/**job_scheduler_unittest.cc
>   M chrome/browser/chromeos/drive/**local_file_reader_unittest.cc
>   M chrome/browser/chromeos/drive/**remove_stale_cache_files_**unittest.cc
>   M chrome/browser/chromeos/drive/**resource_metadata_storage_**
> unittest.cc
>   M chrome/browser/chromeos/drive/**resource_metadata_unittest.cc
>   M chrome/browser/chromeos/drive/**search_metadata_unittest.cc
>   M chrome/browser/chromeos/drive/**sync_client_unittest.cc
>   M chrome/browser/chromeos/drive/**webkit_file_stream_reader_**
> impl_unittest.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> browser_private_api.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> handler_util.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> manager_util.cc
>   M chrome/browser/chromeos/**extensions/file_manager/zip_**
> file_creator.cc
>   M chrome/browser/chromeos/**fileapi/remote_file_stream_**writer.cc
>   M chrome/browser/chromeos/kiosk_**mode/kiosk_mode_screensaver.cc
>   M chrome/browser/chromeos/**policy/device_local_account_**
> policy_store.cc
>   M chrome/browser/chromeos/**screensaver/screensaver_**controller.cc
>   M chrome/browser/chromeos/**settings/device_oauth2_token_**
> service_unittest.cc
>   M chrome/browser/chromeos/**settings/device_settings_**
> service_unittest.cc
>   M chrome/browser/chromeos/**settings/session_manager_**operation.cc
>   M chrome/browser/chromeos/**settings/session_manager_**
> operation_unittest.cc
>   M chrome/browser/chromeos/swap_**metrics.cc
>   M chrome/browser/chromeos/**system_logs/chrome_internal_**log_source.cc
>   M chrome/browser/nacl_host/nacl_**host_message_filter.cc
>   M chrome/browser/ui/views/**collected_cookies_views.cc
>   M chrome/browser/ui/views/**select_file_dialog_extension.**cc
>   M chrome/browser/ui/webui/help/**help_handler.cc
>   M chrome/test/data/webui/**certificate_viewer_ui_test-**inl.h
>   M chromeos/network/onc/onc_**utils.cc
>   M content/browser/indexed_db/**indexed_db_callbacks.cc
>   M content/browser/indexed_db/**indexed_db_database_callbacks.**cc
>   M content/browser/renderer_host/**image_transport_factory.cc
>   M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>   M content/browser/web_contents/**web_contents_view_aura.cc
>   M content/renderer/media/rtc_**encoding_video_capturer.cc
>   M ui/aura/window.cc
>   M ui/base/x/selection_utils.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[use derat at chromium.org, 2013-07-03 00:20:26]

Ryan, your changes look like they're getting associated with the wrong bug.
http://crbug.com/206189 is a Chrome OS testing issue from 2011.

Is this based on the "scoped_refptr<T>::operator T*" chromium-dev thread
from a year and a half ago, or something else? I'm pretty sure that I've
received review feedback within the last few months (don't remember from
whom) specifically asking me to use the implicit form when checking a
scoped_ptr for NULL-ness. A more widespread announcement may be needed,
assuming that I didn't miss it.


On Tue, Jul 2, 2013 at 4:56 PM, <rsleevi@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> TBR
>
> Description:
> Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator
> T*"
>
> Fixes a number of cases either not caught by the automated tool or that
> have recently regressed.
>
> BUG=206189
> TBR=darin
>
> Please review this at
https://codereview.chromium.**org/18308004/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/desktop_background/**desktop_background_controller.**cc
>   M cc/test/fake_picture_layer_**tiling_client.h
>   M chrome/browser/chromeos/**camera_detector.cc
>   M chrome/browser/chromeos/drive/**change_list_loader_unittest.cc
>   M chrome/browser/chromeos/drive/**change_list_processor_**unittest.cc
>   M chrome/browser/chromeos/drive/**drive_app_registry_unittest.cc
>   M chrome/browser/chromeos/drive/**drive_file_stream_reader_**unittest.cc
>   M chrome/browser/chromeos/drive/**drive_integration_service.cc
>   M chrome/browser/chromeos/drive/**drive_url_request_job_**unittest.cc
>   M chrome/browser/chromeos/drive/**file_cache.cc
>   M chrome/browser/chromeos/drive/**file_cache_unittest.cc
>   M chrome/browser/chromeos/drive/**file_system/operation_test_**base.cc
>   M chrome/browser/chromeos/drive/**file_system_proxy.cc
>   M chrome/browser/chromeos/drive/**file_system_unittest.cc
>   M chrome/browser/chromeos/drive/**job_scheduler_unittest.cc
>   M chrome/browser/chromeos/drive/**local_file_reader_unittest.cc
>   M chrome/browser/chromeos/drive/**remove_stale_cache_files_**unittest.cc
>   M chrome/browser/chromeos/drive/**resource_metadata_storage_**
> unittest.cc
>   M chrome/browser/chromeos/drive/**resource_metadata_unittest.cc
>   M chrome/browser/chromeos/drive/**search_metadata_unittest.cc
>   M chrome/browser/chromeos/drive/**sync_client_unittest.cc
>   M chrome/browser/chromeos/drive/**webkit_file_stream_reader_**
> impl_unittest.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> browser_private_api.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> handler_util.cc
>   M chrome/browser/chromeos/**extensions/file_manager/file_**
> manager_util.cc
>   M chrome/browser/chromeos/**extensions/file_manager/zip_**
> file_creator.cc
>   M chrome/browser/chromeos/**fileapi/remote_file_stream_**writer.cc
>   M chrome/browser/chromeos/kiosk_**mode/kiosk_mode_screensaver.cc
>   M chrome/browser/chromeos/**policy/device_local_account_**
> policy_store.cc
>   M chrome/browser/chromeos/**screensaver/screensaver_**controller.cc
>   M chrome/browser/chromeos/**settings/device_oauth2_token_**
> service_unittest.cc
>   M chrome/browser/chromeos/**settings/device_settings_**
> service_unittest.cc
>   M chrome/browser/chromeos/**settings/session_manager_**operation.cc
>   M chrome/browser/chromeos/**settings/session_manager_**
> operation_unittest.cc
>   M chrome/browser/chromeos/swap_**metrics.cc
>   M chrome/browser/chromeos/**system_logs/chrome_internal_**log_source.cc
>   M chrome/browser/nacl_host/nacl_**host_message_filter.cc
>   M chrome/browser/ui/views/**collected_cookies_views.cc
>   M chrome/browser/ui/views/**select_file_dialog_extension.**cc
>   M chrome/browser/ui/webui/help/**help_handler.cc
>   M chrome/test/data/webui/**certificate_viewer_ui_test-**inl.h
>   M chromeos/network/onc/onc_**utils.cc
>   M content/browser/indexed_db/**indexed_db_callbacks.cc
>   M content/browser/indexed_db/**indexed_db_database_callbacks.**cc
>   M content/browser/renderer_host/**image_transport_factory.cc
>   M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>   M content/browser/web_contents/**web_contents_view_aura.cc
>   M content/renderer/media/rtc_**encoding_video_capturer.cc
>   M ui/aura/window.cc
>   M ui/base/x/selection_utils.cc
>
>
>

[Ryan Sleevi, 2013-07-03 00:24:11]

On 2013/07/03 00:20:26, use derat at chromium.org wrote:
> Ryan, your changes look like they're getting associated with the wrong bug.
> http://crbug.com/206189 is a Chrome OS testing issue from 2011.
> 
> Is this based on the "scoped_refptr<T>::operator T*" chromium-dev thread
> from a year and a half ago, or something else? I'm pretty sure that I've
> received review feedback within the last few months (don't remember from
> whom) specifically asking me to use the implicit form when checking a
> scoped_ptr for NULL-ness. A more widespread announcement may be needed,
> assuming that I didn't miss it.
> 

Ack! Copy-paste fail

http://crbug.com/110610 contains the bug, along with the steps:

Namely:
- converting *all* uses to .get()
- removing implicit operator
- adding implicit bool trick (per scoped_ptr)
- converting .get()->bool to use implicit bool trick
- profit

The distinct steps for removing the implicit operator and adding the implicit
bool are necessary to avoid compiler ambiguity (eg: a bool promotion to integral
type to a pointer)

[use derat at chromium.org, 2013-07-03 02:34:57]

Makes sense. Thanks for the details!


On Tue, Jul 2, 2013 at 5:24 PM, <rsleevi@chromium.org> wrote:

> On 2013/07/03 00:20:26, use derat at chromium.org wrote:
>
>> Ryan, your changes look like they're getting associated with the wrong
>> bug.
>> http://crbug.com/206189 is a Chrome OS testing issue from 2011.
>>
>
>  Is this based on the "scoped_refptr<T>::operator T*" chromium-dev thread
>> from a year and a half ago, or something else? I'm pretty sure that I've
>> received review feedback within the last few months (don't remember from
>> whom) specifically asking me to use the implicit form when checking a
>> scoped_ptr for NULL-ness. A more widespread announcement may be needed,
>> assuming that I didn't miss it.
>>
>
>
> Ack! Copy-paste fail
>
> http://crbug.com/110610 contains the bug, along with the steps:
>
> Namely:
> - converting *all* uses to .get()
> - removing implicit operator
> - adding implicit bool trick (per scoped_ptr)
> - converting .get()->bool to use implicit bool trick
> - profit
>
> The distinct steps for removing the implicit operator and adding the
> implicit
> bool are necessary to avoid compiler ambiguity (eg: a bool promotion to
> integral
> type to a pointer)
>
>
https://codereview.chromium.**org/18308004/<https://codereview.chromium.org/1...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[use derat at chromium.org, 2013-07-03 02:34:57]

Makes sense. Thanks for the details!


On Tue, Jul 2, 2013 at 5:24 PM, <rsleevi@chromium.org> wrote:

> On 2013/07/03 00:20:26, use derat at chromium.org wrote:
>
>> Ryan, your changes look like they're getting associated with the wrong
>> bug.
>> http://crbug.com/206189 is a Chrome OS testing issue from 2011.
>>
>
>  Is this based on the "scoped_refptr<T>::operator T*" chromium-dev thread
>> from a year and a half ago, or something else? I'm pretty sure that I've
>> received review feedback within the last few months (don't remember from
>> whom) specifically asking me to use the implicit form when checking a
>> scoped_ptr for NULL-ness. A more widespread announcement may be needed,
>> assuming that I didn't miss it.
>>
>
>
> Ack! Copy-paste fail
>
> http://crbug.com/110610 contains the bug, along with the steps:
>
> Namely:
> - converting *all* uses to .get()
> - removing implicit operator
> - adding implicit bool trick (per scoped_ptr)
> - converting .get()->bool to use implicit bool trick
> - profit
>
> The distinct steps for removing the implicit operator and adding the
> implicit
> bool are necessary to avoid compiler ambiguity (eg: a bool promotion to
> integral
> type to a pointer)
>
>
https://codereview.chromium.**org/18308004/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-07-03 04:21:18]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-07-03 04:34:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/18308004/1

[commit-bot: I haz the power, 2013-07-03 04:34:42]

Failed to apply patch for content/browser/indexed_db/indexed_db_callbacks.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/indexed_db/indexed_db_callbacks.cc
  Hunk #1 succeeded at 67 (offset -6 lines).
  Hunk #2 succeeded at 75 (offset -6 lines).
  Hunk #3 FAILED at 98.
  Hunk #4 FAILED at 110.
  Hunk #5 FAILED at 136.
  Hunk #6 FAILED at 168.
  Hunk #7 succeeded at 187 (offset -6 lines).
  Hunk #8 succeeded at 222 (offset -6 lines).
  Hunk #9 succeeded at 252 (offset -6 lines).
  Hunk #10 succeeded at 273 with fuzz 2 (offset -6 lines).
  Hunk #11 succeeded at 292 (offset -5 lines).
  Hunk #12 succeeded at 305 (offset -5 lines).
  Hunk #13 succeeded at 318 with fuzz 2 (offset -5 lines).
  4 out of 13 hunks FAILED -- saving rejects to file
content/browser/indexed_db/indexed_db_callbacks.cc.rej

Patch:       content/browser/indexed_db/indexed_db_callbacks.cc
Index: content/browser/indexed_db/indexed_db_callbacks.cc
diff --git a/content/browser/indexed_db/indexed_db_callbacks.cc
b/content/browser/indexed_db/indexed_db_callbacks.cc
index
b0f063e3562ca8b8fd85378f4e7d1c2d12ae5f8c..9d627a3550382b11d99977ccbdfa4d76b661239d
100644
--- a/content/browser/indexed_db/indexed_db_callbacks.cc
+++ b/content/browser/indexed_db/indexed_db_callbacks.cc
@@ -73,7 +73,7 @@
IndexedDBCallbacks::IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
 IndexedDBCallbacks::~IndexedDBCallbacks() {}
 
 void IndexedDBCallbacks::OnError(const IndexedDBDatabaseError& error) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   dispatcher_host_->Send(new IndexedDBMsg_CallbacksError(
       ipc_thread_id_, ipc_callbacks_id_, error.code(), error.message()));
@@ -81,7 +81,7 @@ void IndexedDBCallbacks::OnError(const IndexedDBDatabaseError&
error) {
 }
 
 void IndexedDBCallbacks::OnSuccess(const std::vector<string16>& value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -98,7 +98,7 @@ void IndexedDBCallbacks::OnSuccess(const
std::vector<string16>& value) {
 }
 
 void IndexedDBCallbacks::OnBlocked(int64 existing_version) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
 
   dispatcher_host_->Send(new IndexedDBMsg_CallbacksIntBlocked(
@@ -110,7 +110,7 @@ void IndexedDBCallbacks::OnUpgradeNeeded(
     scoped_refptr<IndexedDBDatabase> database,
     const IndexedDBDatabaseMetadata& metadata,
     WebIDBCallbacks::DataLoss data_loss) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   did_create_proxy_ = true;
 
@@ -136,7 +136,7 @@ void IndexedDBCallbacks::OnUpgradeNeeded(
 
 void IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBDatabase> database,
                                    const IndexedDBDatabaseMetadata& metadata) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
 
   scoped_refptr<IndexedDBCallbacks> self(this);
@@ -168,13 +168,13 @@ void
IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
                                    const IndexedDBKey& key,
                                    const IndexedDBKey& primary_key,
                                    std::vector<char>* value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
   DCHECK_EQ(kNoDatabaseCallbacks, ipc_database_callbacks_id_);
 
-  int32 ipc_object_id = dispatcher_host_->Add(cursor);
+  int32 ipc_object_id = dispatcher_host_->Add(cursor.get());
   IndexedDBMsg_CallbacksSuccessIDBCursor_Params params;
   params.ipc_thread_id = ipc_thread_id_;
   params.ipc_callbacks_id = ipc_callbacks_id_;
@@ -193,7 +193,7 @@ void
IndexedDBCallbacks::OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
 void IndexedDBCallbacks::OnSuccess(const IndexedDBKey& key,
                                    const IndexedDBKey& primary_key,
                                    std::vector<char>* value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_NE(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -228,7 +228,7 @@ void IndexedDBCallbacks::OnSuccessWithPrefetch(
   DCHECK_EQ(keys.size(), primary_keys.size());
   DCHECK_EQ(keys.size(), values.size());
 
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_NE(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -258,7 +258,7 @@ void IndexedDBCallbacks::OnSuccessWithPrefetch(
 void IndexedDBCallbacks::OnSuccess(std::vector<char>* value,
                                    const IndexedDBKey& key,
                                    const IndexedDBKeyPath& key_path) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -279,7 +279,7 @@ void IndexedDBCallbacks::OnSuccess(std::vector<char>* value,
 }
 
 void IndexedDBCallbacks::OnSuccess(std::vector<char>* value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);
@@ -297,7 +297,7 @@ void IndexedDBCallbacks::OnSuccess(std::vector<char>* value)
{
 }
 
 void IndexedDBCallbacks::OnSuccess(const IndexedDBKey& value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -310,7 +310,7 @@ void IndexedDBCallbacks::OnSuccess(const IndexedDBKey&
value) {
 }
 
 void IndexedDBCallbacks::OnSuccess(int64 value) {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoCursor, ipc_cursor_id_);
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
@@ -323,7 +323,7 @@ void IndexedDBCallbacks::OnSuccess(int64 value) {
 }
 
 void IndexedDBCallbacks::OnSuccess() {
-  DCHECK(dispatcher_host_);
+  DCHECK(dispatcher_host_.get());
 
   DCHECK_EQ(kNoTransaction, host_transaction_id_);
   DCHECK_EQ(kNoDatabase, ipc_database_id_);

[commit-bot: I haz the power, 2013-07-03 17:29:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/18308004/29001

[commit-bot: I haz the power, 2013-07-03 21:44:27]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Ryan Sleevi, 2013-07-03 22:02:01]

Committed patchset #3 manually as r210048 (presubmit successful).