Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1830773004: Fix for build mode SDK options. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
skybrian, Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 9 months ago (2016-03-24 01:12:48 UTC) #1
skybrian
LGTM. I verified that the bazel tests pass with this change.
4 years, 9 months ago (2016-03-24 01:28:13 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as f00f0168b62b6a0b9d2705a2ca656b482785077b (presubmit successful).
4 years, 9 months ago (2016-03-24 01:36:10 UTC) #4
Paul Berry
4 years, 9 months ago (2016-03-24 01:45:42 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698