Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1830733003: Revert of Disable CALayer overlays on 10.9 (Closed)

Created:
4 years, 9 months ago by ccameron
Modified:
4 years, 9 months ago
Reviewers:
erikchen
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@decode_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable CALayer overlays on 10.9 (patchset #2 id:20001 of https://codereview.chromium.org/1819193002/ ) Reason for revert: Wasn't helpful. Original issue's description: > Disable CALayer overlays on 10.9 > > This is causing issues with PDF and print-preview for yet-unknown > reasons. Hopefully we can re-enable CALayer overlays when we find the > fix. > > BUG=594343 > > Committed: https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc > Cr-Commit-Position: refs/heads/master@{#382498} TBR=erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594343 Committed: https://crrev.com/09b6b31bbf4dc3de1ac5f8e31de9fabdd2e9f427 Cr-Commit-Position: refs/heads/master@{#382943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ccameron
Created Revert of Disable CALayer overlays on 10.9
4 years, 9 months ago (2016-03-23 21:41:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830733003/1
4 years, 9 months ago (2016-03-23 21:41:53 UTC) #2
erikchen
lgtm
4 years, 9 months ago (2016-03-23 21:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830733003/1
4 years, 9 months ago (2016-03-23 22:01:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 22:20:17 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:22:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09b6b31bbf4dc3de1ac5f8e31de9fabdd2e9f427
Cr-Commit-Position: refs/heads/master@{#382943}

Powered by Google App Engine
This is Rietveld 408576698