runtime/vm/stack_frame.cc - Issue 1830733002: Fix stub frame walking: when materializing the frame content during deoptimization, the stack is no…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stack_frame.cc

Issue 1830733002: Fix stub frame walking: when materializing the frame content during deoptimization, the stack is no… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Remove change to IsStubFrame; pending investigation. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stack_frame.cc

diff --git a/runtime/vm/stack_frame.cc b/runtime/vm/stack_frame.cc

index 4eb3da7e0d6b94b8b256e9f66d641093e2f3fd6a..f54ee8afdb368cc8eb2e079c3b9132349f683c95 100644

--- a/runtime/vm/stack_frame.cc

+++ b/runtime/vm/stack_frame.cc

@@ -28,7 +28,7 @@ bool StackFrame::IsStubFrame() const {

NoSafepointScope no_safepoint;

#endif

RawCode* code = GetCodeObject();

- intptr_t cid = code->ptr()->owner_->GetClassId();

+ const intptr_t cid = code->ptr()->owner_->GetClassId();

ASSERT(cid == kNullCid || cid == kClassCid || cid == kFunctionCid);

return cid == kNullCid || cid == kClassCid;

}

« no previous file with comments | « runtime/vm/raw_object.cc ('k') | no next file » | no next file with comments »