Fix stub frame walking: when materializing the frame content during deoptimization, the stack is no…

Fix stub frame walking: when materializing the frame content during deoptimization, the stack is not yet set up properly (missing code object). This happens when background compiler requires GC.

Revert fixes other crashes in stack walk.
Revert "Reapply "Remove Code::active_instructions_.""

This reverts commit 28846c4bd4ba97e1bce00cf33f700b986a19e4eb.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/389dad87f70baf6ae51440ae4d6cb31ed6914132

[srdjan, 2016-03-23 19:40:25]

Description was changed from

==========
Fix stub frame walking: when materializing the frame content during
deoptimization, the stack is not yet set up properly (missing code object). This
happens when background compiler requires GC.


Revert "Reapply "Remove Code::active_instructions_.""

This reverts commit 28846c4bd4ba97e1bce00cf33f700b986a19e4eb.

BUG=
==========

to

==========
Fix stub frame walking: when materializing the frame content during
deoptimization, the stack is not yet set up properly (missing code object). This
happens when background compiler requires GC.

Revert fixes other crashes in stack walk.
Revert "Reapply "Remove Code::active_instructions_.""

This reverts commit 28846c4bd4ba97e1bce00cf33f700b986a19e4eb.

BUG=
==========

[srdjan, 2016-03-23 19:40:38]

srdjan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-03-23 19:44:19]

lgtm

https://codereview.chromium.org/1830733002/diff/1/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/1830733002/diff/1/runtime/vm/stack_frame.cc#n...
runtime/vm/stack_frame.cc:35: return code.IsStubCode();
assert code not null

[srdjan, 2016-03-23 19:48:23]

https://codereview.chromium.org/1830733002/diff/1/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/1830733002/diff/1/runtime/vm/stack_frame.cc#n...
runtime/vm/stack_frame.cc:35: return code.IsStubCode();
On 2016/03/23 19:44:19, rmacnak wrote:
> assert code not null

Done.

[srdjan, 2016-03-23 21:42:56]

Description was changed from

==========
Fix stub frame walking: when materializing the frame content during
deoptimization, the stack is not yet set up properly (missing code object). This
happens when background compiler requires GC.

Revert fixes other crashes in stack walk.
Revert "Reapply "Remove Code::active_instructions_.""

This reverts commit 28846c4bd4ba97e1bce00cf33f700b986a19e4eb.

BUG=
==========

to

==========
Fix stub frame walking: when materializing the frame content during
deoptimization, the stack is not yet set up properly (missing code object). This
happens when background compiler requires GC.

Revert fixes other crashes in stack walk.
Revert "Reapply "Remove Code::active_instructions_.""

This reverts commit 28846c4bd4ba97e1bce00cf33f700b986a19e4eb.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/389dad87f70baf6ae51440ae4d6cb31ed6914132
==========

[srdjan, 2016-03-23 21:42:58]

Committed patchset #4 (id:60001) manually as
389dad87f70baf6ae51440ae4d6cb31ed6914132 (presubmit successful).