Refactor the ring buffer in GCTracer.

Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO

Committed: https://crrev.com/c42b2c4493c128ce6e8d7d32280573a876a5b8c4
Cr-Commit-Position: refs/heads/master@{#35104}

[ulan, 2016-03-29 11:15:46]

Description was changed from

==========
GC tracer

BUG=
==========

to

==========
Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO
==========

[ulan, 2016-03-29 11:15:46]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2016-03-29 11:17:12]

ptal

[Hannes Payer (out of office), 2016-03-29 11:37:38]

I like it!
LGTM

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:660: int GCTracer::AverageSpeed(const
RingBuffer<BytesAndDuration>& buffer,
How about returning double here?

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:467: RingBuffer<BytesAndDuration>
past_incremental_marking_steps_;
past -> recorded

[ulan, 2016-03-29 12:13:07]

Thanks

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:660: int GCTracer::AverageSpeed(const
RingBuffer<BytesAndDuration>& buffer,
On 2016/03/29 11:37:38, Hannes Payer wrote:
> How about returning double here?

Yes, I am going to change all function to return double in a separate CL to make
bisecting easier.

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:467: RingBuffer<BytesAndDuration>
past_incremental_marking_steps_;
On 2016/03/29 11:37:38, Hannes Payer wrote:
> past -> recorded

Done.

[Hannes Payer (out of office), 2016-03-29 12:18:34]

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1830723004/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:660: int GCTracer::AverageSpeed(const
RingBuffer<BytesAndDuration>& buffer,
On 2016/03/29 12:13:07, ulan wrote:
> On 2016/03/29 11:37:38, Hannes Payer wrote:
> > How about returning double here?
> 
> Yes, I am going to change all function to return double in a separate CL to
make
> bisecting easier.

Ack, cool!

[ulan, 2016-03-29 12:20:09]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-03-29 12:20:09]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1830723004/#ps80001
(title: "Fix cast")

[commit-bot: I haz the power, 2016-03-29 12:20:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830723004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830723004/80001

[commit-bot: I haz the power, 2016-03-29 12:51:47]

Description was changed from

==========
Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO
==========

to

==========
Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO
==========

[commit-bot: I haz the power, 2016-03-29 12:51:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-29 12:52:13]

Description was changed from

==========
Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO
==========

to

==========
Refactor the ring buffer in GCTracer.

Now instead of saving all event details in the ring buffer,
we save only the bytes and duration.

This reduces the GCTracer size from 20K to 3K and simplifies code.

BUG=chromium:597310
LOG=NO

Committed: https://crrev.com/c42b2c4493c128ce6e8d7d32280573a876a5b8c4
Cr-Commit-Position: refs/heads/master@{#35104}
==========

[commit-bot: I haz the power, 2016-03-29 12:52:14]

Patchset 5 (id:??) landed as
https://crrev.com/c42b2c4493c128ce6e8d7d32280573a876a5b8c4
Cr-Commit-Position: refs/heads/master@{#35104}