Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 1830703002: Pass AnalysisOptions into SdkCreator, disable changing afterwards. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index c16924a5c96c2db94942014b67a215c4301ce421..6f717216e5e1cde903418e074376d73d662f7f0e 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -250,10 +250,12 @@ void sendAnalysisNotificationOverrides(
* Sets the cache size in the given [context] to the given value.
*/
void setCacheSize(AnalysisContext context, int cacheSize) {
- AnalysisOptionsImpl options =
- new AnalysisOptionsImpl.from(context.analysisOptions);
- options.cacheSize = cacheSize;
- context.analysisOptions = options;
+ // TODO(scheglov) The cache size cannot be changed with task model.
+ // TODO(scheglov) Consider removing this function.
+// AnalysisOptionsImpl options =
+// new AnalysisOptionsImpl.from(context.analysisOptions);
+// options.cacheSize = cacheSize;
+// context.analysisOptions = options;
}
String _computeLibraryName(CompilationUnit unit) {
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698