Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1830703002: Pass AnalysisOptions into SdkCreator, disable changing afterwards. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass AnalysisOptions into SdkCreator, disable changing afterwards. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c675ba270f144e5055d70bd41612f67decfb7540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -33 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 4 chunks +31 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-23 19:13:41 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-23 19:58:37 UTC) #2
scheglov
4 years, 9 months ago (2016-03-23 20:11:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c675ba270f144e5055d70bd41612f67decfb7540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698