Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1830693003: Default no-locals to 0 in dex.py. (Closed)

Created:
4 years, 9 months ago by Yaron
Modified:
4 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default no-locals to 0 in dex.py. gyp always specified a value for --no-locals when compiling targets but GN doesn't. This resulted in GN erroneously stripping them. BUG=596134 Committed: https://crrev.com/5c1bca05189d7e8024b848e25ecb2813b53b6056 Cr-Commit-Position: refs/heads/master@{#382985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/dex.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yaron
4 years, 9 months ago (2016-03-23 20:58:51 UTC) #2
agrieve
lgtm! Can't believe I missed that! I'm tempted to say it should be switched to ...
4 years, 9 months ago (2016-03-23 23:57:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830693003/1
4 years, 9 months ago (2016-03-24 00:09:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 00:14:13 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:15:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1bca05189d7e8024b848e25ecb2813b53b6056
Cr-Commit-Position: refs/heads/master@{#382985}

Powered by Google App Engine
This is Rietveld 408576698