test/unittests/wasm/loop-assignment-analysis-unittest.cc - Issue 1830663002: [wasm] Binary 11: AST changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/wasm/loop-assignment-analysis-unittest.cc

Issue 1830663002: [wasm] Binary 11: AST changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/wasm/loop-assignment-analysis-unittest.cc

diff --git a/test/unittests/wasm/loop-assignment-analysis-unittest.cc b/test/unittests/wasm/loop-assignment-analysis-unittest.cc

index e77c1cfff54306aed9124be57920b5aa82ae1767..d4148020fb005cccd7f2a5908e1a676730d034e3 100644

--- a/test/unittests/wasm/loop-assignment-analysis-unittest.cc

+++ b/test/unittests/wasm/loop-assignment-analysis-unittest.cc

@@ -184,7 +184,7 @@ TEST_F(WasmLoopAssignmentAnalyzerTest, Loop2) {

WASM_STORE_MEM(MachineType::Float32(), WASM_ZERO, WASM_GET_LOCAL(kSum)),

WASM_GET_LOCAL(kIter))};

- BitVector* assigned = Analyze(code + 2, code + arraysize(code));

+ BitVector* assigned = Analyze(code + 1, code + arraysize(code));

for (int j = 0; j < assigned->length(); j++) {

bool expected = j == kIter || j == kSum;

CHECK_EQ(expected, assigned->Contains(j));