Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1830623002: Roll WebGL 1012e1f..d73a29e (Closed)

Created:
4 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, yunchao, qiankun, Jamie Madill, Geoff Lang, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 1012e1f..d73a29e https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1012e1f..d73a29e BUG=594021 TEST=bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Russell (switch to Gerrit)
PTAL If this passes the trybots, will CQ it; if WebGL 2.0 conformance failures are ...
4 years, 9 months ago (2016-03-23 17:20:02 UTC) #3
bajones
LGTM
4 years, 9 months ago (2016-03-23 19:31:12 UTC) #4
Zhenyao Mo
On 2016/03/23 19:31:12, bajones wrote: > LGTM Ken, I have a roll (https://codereview.chromium.org/1802803002/) ready to ...
4 years, 9 months ago (2016-03-23 20:54:24 UTC) #5
Ken Russell (switch to Gerrit)
4 years, 9 months ago (2016-03-23 21:22:49 UTC) #6
On 2016/03/23 20:54:24, Zhenyao Mo wrote:
> On 2016/03/23 19:31:12, bajones wrote:
> > LGTM
> 
> Ken, I have a roll (https://codereview.chromium.org/1802803002/) ready to
land.
> 
> I think my roll should remove most if not all of the failures.  Can you rebase
> once mine lands? Sorry my roll got delayed because I forgot about it.

Thanks Mo, yes, please go ahead and land your roll. I had quite some difficulty
figuring out all the suppressions and wasn't even done yet.

Powered by Google App Engine
This is Rietveld 408576698