Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 1830613002: Add newlines to EOF in C++ .tmpl files. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add newlines to EOF in C++ .tmpl files. So that people can build with -Wnewline-eof if they want. TBR=vardhan@google.com BUG=Fixes #728 Committed: https://chromium.googlesource.com/external/mojo/+/5e92bca8578c4e2f4caf95c19786f2310044875a

Patch Set 1 #

Messages

Total messages: 3 (2 generated)
viettrungluu
4 years, 9 months ago (2016-03-23 17:01:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e92bca8578c4e2f4caf95c19786f2310044875a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698