Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1830543002: Make some chrome feature flags customizable in GN build (Closed)

Created:
4 years, 9 months ago by Tomasz Moniuszko
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some chrome feature flags customizable in GN build These flags are customizable in GYP build. BUG= Committed: https://crrev.com/233bbd6b46f28867f040078923f9809937736340 Cr-Commit-Position: refs/heads/master@{#382854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/common/features.gni View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 9 months ago (2016-03-23 11:21:20 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-23 15:28:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830543002/1
4 years, 9 months ago (2016-03-23 15:39:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 16:11:04 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 16:12:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/233bbd6b46f28867f040078923f9809937736340
Cr-Commit-Position: refs/heads/master@{#382854}

Powered by Google App Engine
This is Rietveld 408576698