Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1830523003: 🌛 Consider resource names in md5_check for process_resources (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider resource names in md5_check for process_resources This matters when a file is renamed but not changed. BUG=597126 Committed: https://crrev.com/3ab115fa857658726e2a8756f250b6f33c78e701 Cr-Commit-Position: refs/heads/master@{#383751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/android/gyp/process_resources.py View 1 chunk +9 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/03/23 15:27:26, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:ianwen@chromium.org ping
4 years, 9 months ago (2016-03-24 23:40:17 UTC) #3
Ian Wen
Thank you for fixing it so fast! The change lgtm.
4 years, 9 months ago (2016-03-25 00:21:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830523003/1
4 years, 8 months ago (2016-03-29 16:00:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 17:15:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:17:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ab115fa857658726e2a8756f250b6f33c78e701
Cr-Commit-Position: refs/heads/master@{#383751}

Powered by Google App Engine
This is Rietveld 408576698