Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1830513003: Move AcceleratedSurfaceBuffersSwappedParams to content/common (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
dcheng, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AcceleratedSurfaceBuffersSwappedParams to content/common This struct is used for browser<=>gpu IPC. As with EstablishChannelParams, this CL moves this struct to content/common and removes its usage from within content/common/gpu BUG=596290 Committed: https://crrev.com/521c72b8e01db6716892e82b8fb5d23864766ae7 Cr-Commit-Position: refs/heads/master@{#383117}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix unit tests #

Total comments: 2

Patch Set 4 : Addressed piman's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -75 lines) Patch
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/accelerated_surface_buffers_swapped_params_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/accelerated_surface_buffers_swapped_params_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/accelerated_surface_buffers_swapped_params_mac.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/common/gpu/accelerated_surface_buffers_swapped_params_mac.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_delegate.h View 1 2 3 4 chunks +15 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_channel_test_common.h View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_test_common.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.h View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 2 3 3 chunks +20 lines, -12 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Fady Samuel
+piman@: overall review. +dcheng@: IPC PTAL Thanks!
4 years, 9 months ago (2016-03-24 03:48:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830513003/20001
4 years, 9 months ago (2016-03-24 03:49:35 UTC) #4
dcheng
rs lgtm for ipcchanges.
4 years, 9 months ago (2016-03-24 03:50:11 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/177495)
4 years, 9 months ago (2016-03-24 04:05:25 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830513003/40001
4 years, 9 months ago (2016-03-24 04:14:43 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 05:25:28 UTC) #11
piman
lgtm https://codereview.chromium.org/1830513003/diff/40001/content/gpu/gpu_child_thread.cc File content/gpu/gpu_child_thread.cc (right): https://codereview.chromium.org/1830513003/diff/40001/content/gpu/gpu_child_thread.cc#newcode337 content/gpu/gpu_child_thread.cc:337: const std::vector<ui::LatencyInfo>& latency_info) { nit: make this "std::vector<ui::LatencyInfo> ...
4 years, 9 months ago (2016-03-24 18:02:21 UTC) #12
Fady Samuel
CQ'ed. Thanks! https://codereview.chromium.org/1830513003/diff/40001/content/gpu/gpu_child_thread.cc File content/gpu/gpu_child_thread.cc (right): https://codereview.chromium.org/1830513003/diff/40001/content/gpu/gpu_child_thread.cc#newcode337 content/gpu/gpu_child_thread.cc:337: const std::vector<ui::LatencyInfo>& latency_info) { On 2016/03/24 18:02:21, ...
4 years, 9 months ago (2016-03-24 18:18:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830513003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830513003/60001
4 years, 9 months ago (2016-03-24 18:18:20 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-24 19:19:42 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 19:21:26 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/521c72b8e01db6716892e82b8fb5d23864766ae7
Cr-Commit-Position: refs/heads/master@{#383117}

Powered by Google App Engine
This is Rietveld 408576698