Issue 18305004: Ensure CheckInitialized is present independent of define.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18305004: Ensure CheckInitialized is present independent of define. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger

Modified:
7 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure CheckInitialized is present independent of define. This makes sure that the same symbols are present, independent of which defines have been used while building V8. Otherwise only embedders with compatible defines would be able to link against that binary. R=danno@chromium.org BUG=chromium:255779 Committed: http://code.google.com/p/v8/source/detail?r=15417

Patch Set 1 #

Patch Set 2 : Force inlining. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	include/v8.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 5 months ago (2013-07-01 12:57:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15417 (presubmit successful).

Expand Messages | Collapse Messages