Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1830483002: Revert of Quick fix for broken JS notation (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, Dan Beam, kelvinp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Quick fix for broken JS notation (patchset #1 id:1 of https://codereview.chromium.org/1826603002/ ) Reason for revert: Caused compile failure on 64-bit Android bots. See crbug.com/597155 Original issue's description: > Quick fix for broken JS notation > > Fix for issue: https://codereview.chromium.org/1811833002 > > TBR=sergeyu@chromium.org > BUG= > > Committed: https://crrev.com/bd12932cbd6656a2de7ff0a639b01364dddac013 > Cr-Commit-Position: refs/heads/master@{#382714} TBR=sergeyu@chromium.org,lambroslambrou@chromium.org,yuweih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/24994728bb74a3ef84b84db0c6d9f45e5d410274 Cr-Commit-Position: refs/heads/master@{#382776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/base/js/connection_stats.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
newt (away)
Created Revert of Quick fix for broken JS notation
4 years, 9 months ago (2016-03-23 02:54:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830483002/1
4 years, 9 months ago (2016-03-23 02:54:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 02:55:22 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 02:57:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24994728bb74a3ef84b84db0c6d9f45e5d410274
Cr-Commit-Position: refs/heads/master@{#382776}

Powered by Google App Engine
This is Rietveld 408576698