Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: runtime/vm/profiler_service.h

Issue 1830473002: Speedup function profile by using a hash table instead of a linear scan (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_PROFILER_SERVICE_H_ 5 #ifndef VM_PROFILER_SERVICE_H_
6 #define VM_PROFILER_SERVICE_H_ 6 #define VM_PROFILER_SERVICE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/globals.h" 10 #include "vm/globals.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 ASSERT(name_ != NULL); 70 ASSERT(name_ != NULL);
71 return name_; 71 return name_;
72 } 72 }
73 73
74 const char* Name() const; 74 const char* Name() const;
75 75
76 RawFunction* function() const { 76 RawFunction* function() const {
77 return function_.raw(); 77 return function_.raw();
78 } 78 }
79 79
80 const Function* key() const {
81 return &function_;
82 }
Ivan Posva 2016/03/23 15:14:40 Looking at this again this definitely should be co
Cutch 2016/03/23 19:34:21 Done.
83
80 intptr_t table_index() const { 84 intptr_t table_index() const {
81 return table_index_; 85 return table_index_;
82 } 86 }
83 87
84 Kind kind() const { 88 Kind kind() const {
85 return kind_; 89 return kind_;
86 } 90 }
87 91
88 intptr_t exclusive_ticks() const { return exclusive_ticks_; } 92 intptr_t exclusive_ticks() const { return exclusive_ticks_; }
89 intptr_t inclusive_ticks() const { return inclusive_ticks_; } 93 intptr_t inclusive_ticks() const { return inclusive_ticks_; }
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 JSONStream* stream, 468 JSONStream* stream,
465 Profile::TagOrder tag_order, 469 Profile::TagOrder tag_order,
466 intptr_t extra_tags, 470 intptr_t extra_tags,
467 SampleFilter* filter, 471 SampleFilter* filter,
468 bool as_timline); 472 bool as_timline);
469 }; 473 };
470 474
471 } // namespace dart 475 } // namespace dart
472 476
473 #endif // VM_PROFILER_SERVICE_H_ 477 #endif // VM_PROFILER_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698