Change analyzer_cli's "package mode" into a "build mode".

Change analyzer_cli's "package mode" into a "build mode".

Build mode differs from package mode in the following ways:

- The analyzer no longer guesses the relationship between paths and
  URIs based on directory structure.  Instead, each input file is
  specified in the form "$uri|$path".

- The analyzer does not read any files from disk that are not
  specified on the command line.

- There are no restrictions on the relationship between summaries and
  packages.  In particular: (a) multiple input summaries may summarize
  parts of the same package, and (b) part of a package may be
  specified with an input summary while an output summary is being
  generated for other parts of the same package.

- Output may be redirected to a file.

- The analyzer may be told to exit with success even in the event that
  an error is found during analysis.

This should ease the integration with Bazel, and provide a starting
point for integrating with other build systems.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c7e1de177a64f66cbbefcc952c95d3364b2a93d6

[Paul Berry, 2016-03-23 00:53:56]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-03-23 01:11:50]

LGTM

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:311: 'Specefies the path to the file where
analysis results should be written.',
"Specifies"

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:5: library
analyzer_cli.src.package_analyzer;
Do you want to rename this file?
e.g. build_mode.dart

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:185: static Map<Uri, JavaFile>
_createUriToFileMap(List<String> sourceFiles) {
Naming the argument source "files" is a little misleading.
Maybe something more abstract, like "sourceEntities".

[Paul Berry, 2016-03-23 03:28:02]

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:311: 'Specefies the path to the file where
analysis results should be written.',
On 2016/03/23 01:11:50, scheglov wrote:
> "Specifies"

Done.

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:5: library
analyzer_cli.src.package_analyzer;
On 2016/03/23 01:11:50, scheglov wrote:
> Do you want to rename this file?
> e.g. build_mode.dart

Done.

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:185: static Map<Uri, JavaFile>
_createUriToFileMap(List<String> sourceFiles) {
On 2016/03/23 01:11:50, scheglov wrote:
> Naming the argument source "files" is a little misleading.
> Maybe something more abstract, like "sourceEntities".

Done.

[Paul Berry, 2016-03-23 03:38:34]

Description was changed from

==========
Change analyzer_cli's "package mode" into a "build mode".

Build mode differs from package mode in the following ways:

- The analyzer no longer guesses the relationship between paths and
  URIs based on directory structure.  Instead, each input file is
  specified in the form "$uri|$path".

- The analyzer does not read any files from disk that are not
  specified on the command line.

- There are no restrictions on the relationship between summaries and
  packages.  In particular: (a) multiple input summaries may summarize
  parts of the same package, and (b) part of a package may be
  specified with an input summary while an output summary is being
  generated for other parts of the same package.

- Output may be redirected to a file.

- The analyzer may be told to exit with success even in the event that
  an error is found during analysis.

This should ease the integration with Bazel, and provide a starting
point for integrating with other build systems.
==========

to

==========
Change analyzer_cli's "package mode" into a "build mode".

Build mode differs from package mode in the following ways:

- The analyzer no longer guesses the relationship between paths and
  URIs based on directory structure.  Instead, each input file is
  specified in the form "$uri|$path".

- The analyzer does not read any files from disk that are not
  specified on the command line.

- There are no restrictions on the relationship between summaries and
  packages.  In particular: (a) multiple input summaries may summarize
  parts of the same package, and (b) part of a package may be
  specified with an input summary while an output summary is being
  generated for other parts of the same package.

- Output may be redirected to a file.

- The analyzer may be told to exit with success even in the event that
  an error is found during analysis.

This should ease the integration with Bazel, and provide a starting
point for integrating with other build systems.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c7e1de177a64f66cbbefcc952c95d3364b2a93d6
==========

[Paul Berry, 2016-03-23 03:38:35]

Committed patchset #1 (id:1) manually as
c7e1de177a64f66cbbefcc952c95d3364b2a93d6 (presubmit successful).

[Jennifer Messerly, 2016-03-23 17:37:27]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-03-23 17:37:28]

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:81:
entry.setValue(result, SourceKind.PART, TargetedResult.EMPTY_LIST);
Dumb question about this...

Here, it looks like any URI from the unlinkedMap is treated as a "part" and only
a part.

However InSummaryPackageUriResolver below, it seems to treat unlinkedMap as any
file URI coming from the summary (library or part).

Is one of these wrong? Or are library URIs in both maps, and that's how it works
out? (since the LIBRARY check is first).

Anyway just curious.

[scheglov, 2016-03-23 17:43:22]

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/1830463002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:81:
entry.setValue(result, SourceKind.PART, TargetedResult.EMPTY_LIST);
On 2016/03/23 17:37:28, John Messerly wrote:
> Dumb question about this...
> 
> Here, it looks like any URI from the unlinkedMap is treated as a "part" and
only
> a part.
> 
> However InSummaryPackageUriResolver below, it seems to treat unlinkedMap as
any
> file URI coming from the summary (library or part).
> 
> Is one of these wrong? Or are library URIs in both maps, and that's how it
works
> out? (since the LIBRARY check is first).
> 
> Anyway just curious. 

Yes, library URIs are in both maps.