Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1830393002: Revert of Initial addition of blimp crash client code. (Closed)

Created:
4 years, 9 months ago by haibinlu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initial addition of blimp crash client code. (patchset #5 id:80001 of https://codereview.chromium.org/1783053002/ ) Reason for revert: Engine crashes. https://bugs.chromium.org/p/chromium/issues/detail?id=597838 Original issue's description: > Initial addition of Blimp engine crash client code. > > This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name. Crash reporting is enabled for all processes. > > BUG=597454 > > Committed: https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc > Cr-Commit-Position: refs/heads/master@{#383161} TBR=kmarshall@chromium.org,mark@chromium.org,marcinjb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597454 Committed: https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153 Cr-Commit-Position: refs/heads/master@{#383193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -198 lines) Patch
M blimp/engine/BUILD.gn View 2 chunks +0 lines, -18 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/Dockerfile View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/app/blimp_content_main_delegate.cc View 2 chunks +0 lines, -25 lines 0 comments Download
D blimp/engine/app/blimp_engine_crash_keys.h View 1 chunk +0 lines, -20 lines 0 comments Download
D blimp/engine/app/blimp_engine_crash_keys.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/engine/app/blimp_engine_crash_reporter_client.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/engine/app/blimp_engine_crash_reporter_client.cc View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
haibinlu
Created Revert of Initial addition of blimp crash client code.
4 years, 9 months ago (2016-03-24 23:47:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830393002/1
4 years, 9 months ago (2016-03-24 23:48:07 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-24 23:48:09 UTC) #4
Kevin M
lgtm
4 years, 9 months ago (2016-03-24 23:48:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830393002/1
4 years, 9 months ago (2016-03-24 23:49:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 23:49:51 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:50:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153
Cr-Commit-Position: refs/heads/master@{#383193}

Powered by Google App Engine
This is Rietveld 408576698