Chromium Code Reviews
DescriptionWebmMuxer: add Pause()/Resume() methods and internal time-in-pause
See bug for more details, but basically, since WebmMuxer relies on the
incoming video/audio packet timestamp, pausing the recorder (not any
associated MediaStream{Video,Audio}Track), leaves empty gaps in the
output .webm file.
This CL solves this by measuring the elapsed time(s) between Pause()
and Resume(), accumulating the elapsed time(s), then subtracting that
from the output webm file timestamp.
BUG=593560
TEST= manual:
- head for QA page [1] (with --enable-blink-features=GetUserMedia)
- click on "GetUSerMedia"
- select "Stream To Record" "local"
- click "CreateRecorder" then "Start".
- Leave it recording for a A seconds.
- Click "Pause" and wait a B seconds.
- Click "Resume" and wait C seconds.
- Click "Stop" and "Download".
- Play back the generated file and verify that there is
no substantial freezing in the recorded sequence and that
the length of the output file is estimated in A+C seconds.
[1] https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html
Committed: https://crrev.com/768a9b746767f4a4b64a199fd68f9985c7da7ba3
Cr-Commit-Position: refs/heads/master@{#383481}
Patch Set 1 : #
Messages
Total messages: 11 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||