Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1830383003: WebmMuxer: add Pause()/Resume() methods and internal time-in-pause (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
Reviewers:
miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebmMuxer: add Pause()/Resume() methods and internal time-in-pause See bug for more details, but basically, since WebmMuxer relies on the incoming video/audio packet timestamp, pausing the recorder (not any associated MediaStream{Video,Audio}Track), leaves empty gaps in the output .webm file. This CL solves this by measuring the elapsed time(s) between Pause() and Resume(), accumulating the elapsed time(s), then subtracting that from the output webm file timestamp. BUG=593560 TEST= manual: - head for QA page [1] (with --enable-blink-features=GetUserMedia) - click on "GetUSerMedia" - select "Stream To Record" "local" - click "CreateRecorder" then "Start". - Leave it recording for a A seconds. - Click "Pause" and wait a B seconds. - Click "Resume" and wait C seconds. - Click "Stop" and "Download". - Play back the generated file and verify that there is no substantial freezing in the recorded sequence and that the length of the output file is estimated in A+C seconds. [1] https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html Committed: https://crrev.com/768a9b746767f4a4b64a199fd68f9985c7da7ba3 Cr-Commit-Position: refs/heads/master@{#383481}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M content/renderer/media/audio_track_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/muxers/webm_muxer.h View 3 chunks +8 lines, -0 lines 0 comments Download
M media/muxers/webm_muxer.cc View 4 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mcasas
miu@ small CL, PTAL
4 years, 9 months ago (2016-03-25 01:50:29 UTC) #4
miu
lgtm
4 years, 9 months ago (2016-03-25 21:49:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830383003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830383003/20001
4 years, 9 months ago (2016-03-28 05:15:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-28 06:30:46 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-28 06:32:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/768a9b746767f4a4b64a199fd68f9985c7da7ba3
Cr-Commit-Position: refs/heads/master@{#383481}

Powered by Google App Engine
This is Rietveld 408576698