Issue 183038: Fixes crash when switching to new tabs containing audio/video elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183038: Fixes crash when switching to new tabs containing audio/video elements. (Closed)

Created:
11 years, 3 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fixes crash when switching to new tabs containing audio/video elements. Cause was we're calling platformContext(), one of the few GraphicsContext operations that asserts if painting is disabled. BUG=19677, 20138 TEST=open a video in a new background tab, wait a bit, then switch to it -- shouldn't crash

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/api/src/WebMediaPlayerClientImpl.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

This only seems to affect platforms that support control theme tinting (Mac/Linux). I couldn't reproduce ...

11 years, 3 months ago (2009-09-01 22:40:42 UTC) #1

LGTM2

Expand Messages | Collapse Messages