Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 1830343004: Remove extra definitions of SkMovie (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo, Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/ports/SkImageEncoder_CG.cpp View 1 2 chunks +1 line, -9 lines 0 comments Download
M src/ports/SkImageEncoder_WIC.cpp View 1 2 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830343004/1
4 years, 9 months ago (2016-03-25 17:33:25 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1497)
4 years, 9 months ago (2016-03-25 17:34:36 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830343004/20001
4 years, 9 months ago (2016-03-25 17:37:16 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830343004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830343004/40001
4 years, 9 months ago (2016-03-25 17:39:46 UTC) #9
msarett
I think I must caused the following warning on Windows while refactoring... images.SkMovie_FactoryDefault.obj : warning ...
4 years, 9 months ago (2016-03-25 17:57:23 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 18:04:02 UTC) #13
Brian Osman
lgtm
4 years, 9 months ago (2016-03-25 18:06:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830343004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830343004/40001
4 years, 9 months ago (2016-03-25 18:07:00 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:08:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d442d32335a12964af1691b64977621d18048d20

Powered by Google App Engine
This is Rietveld 408576698