chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc - Issue 1830343003: When animating a content setting bubble smaller, hide the background later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

Issue 1830343003: When animating a content setting bubble smaller, hide the background later. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

index a686b587675d6566d41497434d0acef5a3ffa93b..a1b830547ca1d286c7248232f51391e4eba238d5 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

@@ -59,7 +59,8 @@ class TestIconLabelBubbleView : public IconLabelBubbleView {

SkColor GetBorderColor() const override { return kTestColor; }

bool ShouldShowBackground() const override {

- return !IsShrinking() || label()->width() > 0;

+ return !IsShrinking() ||

+ (width() >= MinimumWidthForImageWithBackgroundShown());

}

double WidthMultiplier() const override {

« no previous file with comments | « chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc ('k') | no next file » | no next file with comments »