chrome/browser/ui/views/location_bar/content_setting_image_view.cc - Issue 1830343003: When animating a content setting bubble smaller, hide the background later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 1830343003: When animating a content setting bubble smaller, hide the background later. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

index 9aaf4e464d9f03f1778fe6d61acc5541499025f6..fc23d2ea00520ae84f3af7777a82308fe9722c31 100644

--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc

@@ -176,7 +176,8 @@ SkColor ContentSettingImageView::GetBorderColor() const {

}

bool ContentSettingImageView::ShouldShowBackground() const {

- return (!IsShrinking() || label()->width() > 0) &&

+ return (!IsShrinking() ||

+ (width() >= MinimumWidthForImageWithBackgroundShown())) &&

(slide_animator_.is_animating() || pause_animation_);

}

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | no next file with comments »