Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 1830343003: When animating a content setting bubble smaller, hide the background later. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup
Patch Set: Resync Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.cc
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
index 69568056e7336fc6bba5f02cb0d46239adac7135..04f460552bfd84a63ce41cb9946674b060a71e84 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
@@ -176,7 +176,8 @@ SkColor ContentSettingImageView::GetBorderColor() const {
}
bool ContentSettingImageView::ShouldShowBackground() const {
- return (!IsShrinking() || label()->width() > 0) &&
+ return (!IsShrinking() ||
+ (width() >= MinimumWidthForImageWithBackgroundShown())) &&
(slide_animator_.is_animating() || pause_animation_);
}

Powered by Google App Engine
This is Rietveld 408576698