Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1830343002: Enable DRP config service by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sclittle comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 {"enable-data-reduction-proxy-lo-fi-preview", 1471 {"enable-data-reduction-proxy-lo-fi-preview",
1472 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME, 1472 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME,
1473 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll, 1473 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll,
1474 SINGLE_VALUE_TYPE( 1474 SINGLE_VALUE_TYPE(
1475 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)}, 1475 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)},
1476 {"clear-data-reduction-proxy-data-savings", 1476 {"clear-data-reduction-proxy-data-savings",
1477 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME, 1477 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME,
1478 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll, 1478 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll,
1479 SINGLE_VALUE_TYPE( 1479 SINGLE_VALUE_TYPE(
1480 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)}, 1480 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)},
1481 {"enable-data-reduction-proxy-config-client",
1482 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_NAME,
1483 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_DESCRIPTION, kOsAll,
1484 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1485 kEnableDataReductionProxyConfigClient)},
1486 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST, 1481 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST,
1487 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll, 1482 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll,
1488 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1483 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1489 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME, 1484 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME,
1490 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop, 1485 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop,
1491 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1486 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf,
1492 switches::kDisableAddToShelf)}, 1487 switches::kDisableAddToShelf)},
1493 {"bypass-app-banner-engagement-checks", 1488 {"bypass-app-banner-engagement-checks",
1494 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME, 1489 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME,
1495 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll, 1490 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll,
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1884 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) || 1879 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) ||
1885 !strcmp("enable-data-reduction-proxy-lo-fi-preview", 1880 !strcmp("enable-data-reduction-proxy-lo-fi-preview",
1886 entry.internal_name)) && 1881 entry.internal_name)) &&
1887 channel != version_info::Channel::BETA && 1882 channel != version_info::Channel::BETA &&
1888 channel != version_info::Channel::DEV && 1883 channel != version_info::Channel::DEV &&
1889 channel != version_info::Channel::CANARY && 1884 channel != version_info::Channel::CANARY &&
1890 channel != version_info::Channel::UNKNOWN) { 1885 channel != version_info::Channel::UNKNOWN) {
1891 return true; 1886 return true;
1892 } 1887 }
1893 1888
1894 // enable-data-reduction-proxy-config-client is only available for Chromium
1895 // builds and the Canary/Dev channels.
1896 if (!strcmp("enable-data-reduction-proxy-config-client",
1897 entry.internal_name) &&
1898 channel != version_info::Channel::DEV &&
1899 channel != version_info::Channel::CANARY &&
1900 channel != version_info::Channel::UNKNOWN) {
1901 return true;
1902 }
1903
1904 return false; 1889 return false;
1905 } 1890 }
1906 1891
1907 } // namespace 1892 } // namespace
1908 1893
1909 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage, 1894 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage,
1910 base::CommandLine* command_line, 1895 base::CommandLine* command_line,
1911 flags_ui::SentinelsMode sentinels) { 1896 flags_ui::SentinelsMode sentinels) {
1912 if (command_line->HasSwitch(switches::kNoExperiments)) 1897 if (command_line->HasSwitch(switches::kNoExperiments))
1913 return; 1898 return;
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2015 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2000 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2016 2001
2017 const FeatureEntry* GetFeatureEntries(size_t* count) { 2002 const FeatureEntry* GetFeatureEntries(size_t* count) {
2018 *count = arraysize(kFeatureEntries); 2003 *count = arraysize(kFeatureEntries);
2019 return kFeatureEntries; 2004 return kFeatureEntries;
2020 } 2005 }
2021 2006
2022 } // namespace testing 2007 } // namespace testing
2023 2008
2024 } // namespace about_flags 2009 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698