Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index bf50af9a258f09dd7c7cc13fc9646c23df85c0c4..5d834b4a9271dec45bf361907cc061aa39cb981c 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -1095,7 +1095,7 @@ void PaintLayerScrollableArea::updateScrollCornerStyle()
RefPtr<ComputedStyle> corner = box().hasOverflowClip() ? actualLayoutObject.getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdScrollbarCorner), actualLayoutObject.style()) : PassRefPtr<ComputedStyle>(nullptr);
if (corner) {
if (!m_scrollCorner) {
- m_scrollCorner = LayoutScrollbarPart::createAnonymous(&box().document());
+ m_scrollCorner = LayoutScrollbarPart::createAnonymous(&box().document(), this);
m_scrollCorner->setDangerousOneWayParent(&box());
}
m_scrollCorner->setStyleWithWritingModeOfParent(corner.release());
@@ -1223,7 +1223,7 @@ void PaintLayerScrollableArea::updateResizerStyle()
RefPtr<ComputedStyle> resizer = box().hasOverflowClip() ? actualLayoutObject.getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdResizer), actualLayoutObject.style()) : PassRefPtr<ComputedStyle>(nullptr);
if (resizer) {
if (!m_resizer) {
- m_resizer = LayoutScrollbarPart::createAnonymous(&box().document());
+ m_resizer = LayoutScrollbarPart::createAnonymous(&box().document(), this);
m_resizer->setDangerousOneWayParent(&box());
}
m_resizer->setStyleWithWritingModeOfParent(resizer.release());

Powered by Google App Engine
This is Rietveld 408576698