third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h - Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

index cda3347f92ddef8ab13dd9933e8947e33792a8ef..69d13dd1bea3e8d1d532b963f87c59fc1733153c 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

@@ -182,7 +182,6 @@ private:

void updateIfNeededRecursiveInternal();

// GraphicsLayerClient implementation

- // TODO(wkorman): Fix up needsRepaint implementation as part of reworking scrollbar compositing visual rects.

bool needsRepaint(const GraphicsLayer&) const { return true; }

IntRect computeInterestRect(const GraphicsLayer*, const IntRect&) const override;

void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& interestRect) const override;