Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2804 matching lines...) Expand 10 before | Expand all | Expand 10 after
2815 void PaintLayer::markCompositingContainerChainForNeedsRepaint() 2815 void PaintLayer::markCompositingContainerChainForNeedsRepaint()
2816 { 2816 {
2817 // Need to access compositingState(). We've ensured correct flag setting whe n compositingState() changes. 2817 // Need to access compositingState(). We've ensured correct flag setting whe n compositingState() changes.
2818 DisableCompositingQueryAsserts disabler; 2818 DisableCompositingQueryAsserts disabler;
2819 2819
2820 PaintLayer* layer = this; 2820 PaintLayer* layer = this;
2821 while (true) { 2821 while (true) {
2822 if (layer->compositingState() == PaintsIntoOwnBacking) 2822 if (layer->compositingState() == PaintsIntoOwnBacking)
2823 return; 2823 return;
2824 if (CompositedLayerMapping* groupedMapping = layer->groupedMapping()) { 2824 if (CompositedLayerMapping* groupedMapping = layer->groupedMapping()) {
2825 // TODO(wkorman): As we clean up the CompositedLayerMapping needsRep aint logic to
2826 // delegate to scrollbars, we may be able to remove the line below a s well.
2825 groupedMapping->owningLayer().setNeedsRepaint(); 2827 groupedMapping->owningLayer().setNeedsRepaint();
2826 return; 2828 return;
2827 } 2829 }
2828 2830
2829 PaintLayer* container = layer->compositingContainer(); 2831 PaintLayer* container = layer->compositingContainer();
2830 if (!container) { 2832 if (!container) {
2831 LayoutObject* owner = layer->layoutObject()->frame()->ownerLayoutObj ect(); 2833 LayoutObject* owner = layer->layoutObject()->frame()->ownerLayoutObj ect();
2832 if (!owner) 2834 if (!owner)
2833 break; 2835 break;
2834 container = owner->enclosingLayer(); 2836 container = owner->enclosingLayer();
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
2876 2878
2877 void showLayerTree(const blink::LayoutObject* layoutObject) 2879 void showLayerTree(const blink::LayoutObject* layoutObject)
2878 { 2880 {
2879 if (!layoutObject) { 2881 if (!layoutObject) {
2880 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2882 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2881 return; 2883 return;
2882 } 2884 }
2883 showLayerTree(layoutObject->enclosingLayer()); 2885 showLayerTree(layoutObject->enclosingLayer());
2884 } 2886 }
2885 #endif 2887 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698