Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1830323006: Remove FX_DWORD from XFA. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1043 lines, -1043 lines) Patch
M xfa/fde/css/fde_csscache.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M xfa/fde/css/fde_cssdeclaration.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fde/fde_gedevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_iterator.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fde/fde_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M xfa/fee/fde_txtedtengine.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtpage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtparag.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_algorithm.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M xfa/fgas/crt/fgas_encode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 32 chunks +42 lines, -42 lines 0 comments Download
M xfa/fgas/crt/fgas_system.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_fontutils.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 36 chunks +52 lines, -52 lines 0 comments Download
M xfa/fgas/layout/fgas_linebreak.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.cpp View 27 chunks +50 lines, -50 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 28 chunks +54 lines, -54 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 18 chunks +23 lines, -23 lines 0 comments Download
M xfa/fgas/localization/fgas_localemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/xml/fgas_sax_imp.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 26 chunks +33 lines, -33 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 15 chunks +16 lines, -16 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 19 chunks +21 lines, -21 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M xfa/fwl/core/fwl_gridimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_targetimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 11 chunks +25 lines, -25 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/caret.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/combobox.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/lightwidget/datetimepicker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/listbox.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/lightwidget/scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/theme.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/lightwidget/widget.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/theme/carettp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/checkboxtp.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M xfa/fwl/theme/comboboxtp.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/theme/datetimepickertp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/formtp.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/theme/listboxtp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/monthcalendartp.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/theme/pushbuttontp.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/theme/scrollbartp.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/theme/widgettp.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M xfa/fxbarcode/BC_Utils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/common/BC_CommonBitMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Common.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 17 chunks +19 lines, -19 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpath.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsignature.cpp View 2 chunks +14 lines, -14 lines 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 13 chunks +17 lines, -17 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 19 chunks +42 lines, -42 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 12 chunks +18 lines, -18 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 15 chunks +17 lines, -17 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 26 chunks +26 lines, -26 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_lexer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 23 chunks +26 lines, -26 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 24 chunks +29 lines, -29 lines 0 comments Download
M xfa/fxfa/parser/xfa_objectacc_imp.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxjse/context.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Oliver, purely mechanical change.
4 years, 9 months ago (2016-03-25 20:48:30 UTC) #2
Oliver Chang
Yay RS LGTM
4 years, 9 months ago (2016-03-25 20:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830323006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830323006/1
4 years, 9 months ago (2016-03-25 21:16:36 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:19:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/736f28ab2434e2da1de66ff91b64741483ff...

Powered by Google App Engine
This is Rietveld 408576698