Windows 10 64-bit try server configuration.

Windows 10 64-bit try bot configuration.

Depends on https://codereview.chromium.org/1837443002/

BUG=513354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299575

[Will Harris, 2016-03-25 04:55:33]

Description was changed from

==========
Win10 64-bit try bot

BUG=
==========

to

==========
Windows 10 64-bit try bot configuration.

BUG=513354
==========

[Will Harris, 2016-03-25 04:56:23]

Description was changed from

==========
Windows 10 64-bit try bot configuration.

BUG=513354
==========

to

==========
Windows 10 64-bit try bot configuration.

Depends on https://codereview.chromium.org/1837443002/

BUG=513354
==========

[Paweł Hajdan Jr., 2016-03-25 10:17:06]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-03-25 10:17:07]

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:38: 'Win10 Tests
x64': {
Why is this adding a new bot to main waterfall without CQ coverage?

I recommend we keep it in FYI.

[Will Harris, 2016-03-25 19:38:13]

is there a way to test these configurations e.g. perhaps spit out the test json
files I see checked in?

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:38: 'Win10 Tests
x64': {
On 2016/03/25 10:17:07, Paweł Hajdan Jr. wrote:
> Why is this adding a new bot to main waterfall without CQ coverage?
> 
> I recommend we keep it in FYI.

I'm not sure the "Chromium Win 10" bot on chromium.fyi even uses this
configuration - at least I couldn't find the place that wires the two together.

tbh I think this was always meant to be in the other python file?

I'll keep looking. A lot of this is unfamiliar to me.

[Will Harris, 2016-03-25 19:39:50]

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1958: 'Chromium Win
10': {
Follow-up: the existing FYI bot seems to be here, and I'm leaving that alone.

[Dirk Pranke, 2016-03-28 22:17:12]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-28 22:17:13]

Please run `scripts/slave/unittests/recipe_simulation_test.py train` to generate
/ update the -expected/*.json files for the bots, and make sure that it looks
like they're doing roughly what you'd expect. They won't be 100% accurate, since
they don't read the src-side JSON files to actually reflect which tests to run.

https://codereview.chromium.org/1830323005/diff/40001/masters/master.tryserve...
File masters/master.tryserver.chromium.win/slaves.cfg (right):

https://codereview.chromium.org/1830323005/diff/40001/masters/master.tryserve...
masters/master.tryserver.chromium.win/slaves.cfg:36:
'win10_chromium_x64_rel_ng',
move this back to the 'win8_builders' pool (i.e., revert this change) since we
don't want this in the CQ.

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:38: 'Win10 Tests
x64': {
On 2016/03/25 19:38:13, Will Harris wrote:
> On 2016/03/25 10:17:07, Paweł Hajdan Jr. wrote:
> > Why is this adding a new bot to main waterfall without CQ coverage?
> > 
> > I recommend we keep it in FYI.
> 
> I'm not sure the "Chromium Win 10" bot on chromium.fyi even uses this
> configuration - at least I couldn't find the place that wires the two
together.
> 
> tbh I think this was always meant to be in the other python file?
> 
> I'll keep looking. A lot of this is unfamiliar to me.

Per the email discussion, we agreed that we'll add this to the main CI waterfall
(chromium.win) w/o matching CQ coverage, but provide an optional trybot.

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:40:
'chromium_apply_config': ['ninja_confirm_noop'],
change this to 'chromium_apply_conflig': ['mb', 'ninja_confirm_noop']

so that we will use the src-side MB wrapper and the configs in mb_config.pyl,
and thus switch to GN.

[Will Harris, 2016-03-29 22:14:36]

Patchset #4 (id:60001) has been deleted

[Will Harris, 2016-03-29 22:36:01]

still working out how to run the train script on windows, doesn't like my
python.

https://codereview.chromium.org/1830323005/diff/40001/masters/master.tryserve...
File masters/master.tryserver.chromium.win/slaves.cfg (right):

https://codereview.chromium.org/1830323005/diff/40001/masters/master.tryserve...
masters/master.tryserver.chromium.win/slaves.cfg:36:
'win10_chromium_x64_rel_ng',
On 2016/03/28 22:17:13, Dirk Pranke wrote:
> move this back to the 'win8_builders' pool (i.e., revert this change) since we
> don't want this in the CQ.

Done.

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:38: 'Win10 Tests
x64': {
On 2016/03/28 22:17:13, Dirk Pranke wrote:
> On 2016/03/25 19:38:13, Will Harris wrote:
> > On 2016/03/25 10:17:07, Paweł Hajdan Jr. wrote:
> > > Why is this adding a new bot to main waterfall without CQ coverage?
> > > 
> > > I recommend we keep it in FYI.
> > 
> > I'm not sure the "Chromium Win 10" bot on chromium.fyi even uses this
> > configuration - at least I couldn't find the place that wires the two
> together.
> > 
> > tbh I think this was always meant to be in the other python file?
> > 
> > I'll keep looking. A lot of this is unfamiliar to me.
> 
> Per the email discussion, we agreed that we'll add this to the main CI
waterfall
> (chromium.win) w/o matching CQ coverage, but provide an optional trybot.

Acknowledged.

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:40:
'chromium_apply_config': ['ninja_confirm_noop'],
On 2016/03/28 22:17:13, Dirk Pranke wrote:
> change this to 'chromium_apply_conflig': ['mb', 'ninja_confirm_noop']
> 
> so that we will use the src-side MB wrapper and the configs in mb_config.pyl,
> and thus switch to GN.

Done.

https://codereview.chromium.org/1830323005/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:55:
'parent_buildername': 'Win Builder',
changed this to 'Win x64 Builder'

[Will Harris, 2016-03-29 22:38:34]

Patchset #4 (id:80001) has been deleted

[Dirk Pranke, 2016-03-29 22:40:00]

On 2016/03/29 22:36:01, Will Harris wrote:
> still working out how to run the train script on windows, doesn't like my
> python.

I'd be surprised if you can get that to work at all. Do you have a linux box you
can run the update on?

[Will Harris, 2016-03-29 22:42:55]

On 2016/03/29 22:40:00, Dirk Pranke wrote:
> On 2016/03/29 22:36:01, Will Harris wrote:
> > still working out how to run the train script on windows, doesn't like my
> > python.
> 
> I'd be surprised if you can get that to work at all. Do you have a linux box
you
> can run the update on?

yes that was my next plan, now the latest CL has been uploaded I was going to
just cl patch it down to a linux box.

[Will Harris, 2016-03-29 23:03:26]

https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:62: 'os':
'Windows-10-SP0',
this might need to be updated depending on
https://codereview.chromium.org/1841083002/

[Dirk Pranke, 2016-03-29 23:10:01]

lgtm

https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):

https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium_tests/chromium_win.py:62: 'os':
'Windows-10-SP0',
On 2016/03/29 23:03:25, Will Harris wrote:
> this might need to be updated depending on
> https://codereview.chromium.org/1841083002/

Why? I don't think that CL actually affects what you put in here.

[Will Harris, 2016-03-29 23:13:01]

On 2016/03/29 23:10:01, Dirk Pranke wrote:
> lgtm
> 
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):
> 
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> scripts/slave/recipe_modules/chromium_tests/chromium_win.py:62: 'os':
> 'Windows-10-SP0',
> On 2016/03/29 23:03:25, Will Harris wrote:
> > this might need to be updated depending on
> > https://codereview.chromium.org/1841083002/
> 
> Why? I don't think that CL actually affects what you put in here.

if the os dimension changes from Windows-10-SP0 to Windows-10-10586 or
Windows-10-10240 then the tests won't have any bots to swarm onto any more...?

[Dirk Pranke, 2016-03-29 23:15:16]

On 2016/03/29 23:10:01, Dirk Pranke wrote:
> lgtm
> 
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):
> 
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> scripts/slave/recipe_modules/chromium_tests/chromium_win.py:62: 'os':
> 'Windows-10-SP0',
> On 2016/03/29 23:03:25, Will Harris wrote:
> > this might need to be updated depending on
> > https://codereview.chromium.org/1841083002/
> 
> Why? I don't think that CL actually affects what you put in here.

Oh, sorry, yeah I was looking at the wrong CL.

[Will Harris, 2016-03-29 23:19:02]

On 2016/03/29 23:15:16, Dirk Pranke wrote:
> On 2016/03/29 23:10:01, Dirk Pranke wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> > File scripts/slave/recipe_modules/chromium_tests/chromium_win.py (right):
> > 
> >
>
https://codereview.chromium.org/1830323005/diff/140001/scripts/slave/recipe_m...
> > scripts/slave/recipe_modules/chromium_tests/chromium_win.py:62: 'os':
> > 'Windows-10-SP0',
> > On 2016/03/29 23:03:25, Will Harris wrote:
> > > this might need to be updated depending on
> > > https://codereview.chromium.org/1841083002/
> > 
> > Why? I don't think that CL actually affects what you put in here.
> 
> Oh, sorry, yeah I was looking at the wrong CL.

Well, i'll deal with it if/when it happens, it doesn't appear to have changed
the dimensions of the bots I see available -
https://chromium-swarm.appspot.com/restricted/bot/vm1030-m4

[Will Harris, 2016-03-30 00:28:15]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-03-30 00:28:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830323005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830323005/140001

[commit-bot: I haz the power, 2016-03-30 00:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 00:35:25]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Paweł Hajdan Jr., 2016-03-30 09:15:19]

This is failing tests/masters_recipes_test.py:

error while parsing
/b/build/slave/presubmit_build/build/build/masters/master.chromium.win/master.cfg:

Traceback (most recent call last):
  File
"/b/build/slave/presubmit_build/build/build/scripts/common/master_cfg_utils.py",
line 105, in LoadConfig
    localdict = ExecuteConfig(canonical_config)
  File
"/b/build/slave/presubmit_build/build/build/scripts/common/master_cfg_utils.py",
line 80, in ExecuteConfig
    exec f in localDict
  File
"/b/build/slave/presubmit_build/build/build/masters/master.chromium.win/master.cfg",
line 44, in <module>
    master_utils.VerifySetup(c, slaves)
  File
"/b/build/slave/presubmit_build/build/build/scripts/master/master_utils.py",
line 140, in VerifySetup
    raise InvalidConfig('Builder %s has no slave' % b['name'])
InvalidConfig: Builder Win10 Tests x64 has no slave

I'm fine with Dirk stamping the change after that's fixed - he's an OWNER as
well now.

[Will Harris, 2016-03-30 16:27:33]

On 2016/03/30 09:15:19, Paweł Hajdan Jr. wrote:
> This is failing tests/masters_recipes_test.py:
> 
> error while parsing
>
/b/build/slave/presubmit_build/build/build/masters/master.chromium.win/master.cfg:
> 
> Traceback (most recent call last):
>   File
>
"/b/build/slave/presubmit_build/build/build/scripts/common/master_cfg_utils.py",
> line 105, in LoadConfig
>     localdict = ExecuteConfig(canonical_config)
>   File
>
"/b/build/slave/presubmit_build/build/build/scripts/common/master_cfg_utils.py",
> line 80, in ExecuteConfig
>     exec f in localDict
>   File
>
"/b/build/slave/presubmit_build/build/build/masters/master.chromium.win/master.cfg",
> line 44, in <module>
>     master_utils.VerifySetup(c, slaves)
>   File
> "/b/build/slave/presubmit_build/build/build/scripts/master/master_utils.py",
> line 140, in VerifySetup
>     raise InvalidConfig('Builder %s has no slave' % b['name'])
> InvalidConfig: Builder Win10 Tests x64 has no slave
> 
> I'm fine with Dirk stamping the change after that's fixed - he's an OWNER as
> well now.

Yup I have raised 598936 to get one. Thanks.

[Will Harris, 2016-03-30 18:12:54]

Everything is passing now.

[Dirk Pranke, 2016-03-30 21:12:04]

still lgtm.

[Will Harris, 2016-03-30 21:12:31]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-03-30 21:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830323005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830323005/180001

[commit-bot: I haz the power, 2016-03-30 21:16:21]

Description was changed from

==========
Windows 10 64-bit try bot configuration.

Depends on https://codereview.chromium.org/1837443002/

BUG=513354
==========

to

==========
Windows 10 64-bit try bot configuration.

Depends on https://codereview.chromium.org/1837443002/

BUG=513354

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299575
==========

[commit-bot: I haz the power, 2016-03-30 21:16:22]

Committed patchset #8 (id:180001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299575