Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1830293003: Remove BlimpUiContextFactory (Closed)

Created:
4 years, 9 months ago by enne (OOO)
Modified:
4 years, 9 months ago
Reviewers:
haibinlu, no sievers
CC:
anandc+watch-blimp_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BlimpUiContextFactory This removes the override of the ContextFactory and replaces it by just dropping the OnAcceleratedWidgetAvailable call on the floor. This prevents GetSharedBitmap/ResizeDisplay/CreateOutputSurface from being called at all rather than ignoring them when they got called. R=sievers@chromium.org,haibinlu@chromium.org Committed: https://crrev.com/ae96391ad67ebb128d0e0082bdd9633989fd370b Cr-Commit-Position: refs/heads/master@{#383156}

Patch Set 1 #

Patch Set 2 : Remove blink/engine deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -148 lines) Patch
M blimp/engine/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/engine/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D blimp/engine/app/ui/blimp_ui_context_factory.h View 1 chunk +0 lines, -50 lines 0 comments Download
D blimp/engine/app/ui/blimp_ui_context_factory.cc View 1 1 chunk +0 lines, -86 lines 0 comments Download
M blimp/engine/app/ui/blimp_window_tree_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M blimp/engine/app/ui/blimp_window_tree_host.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.h View 2 chunks +0 lines, -4 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
enne (OOO)
This appears to do the right thing for me when I run locally. It seems ...
4 years, 9 months ago (2016-03-24 18:26:45 UTC) #1
no sievers
LGTM
4 years, 9 months ago (2016-03-24 18:37:53 UTC) #2
no sievers
Can you remove the "content/browser/compositor" DEPS entry again now for the blimp engine, so that ...
4 years, 9 months ago (2016-03-24 18:40:25 UTC) #3
haibinlu
lgtm Thanks!
4 years, 9 months ago (2016-03-24 18:44:04 UTC) #5
enne (OOO)
On 2016/03/24 at 18:40:25, sievers wrote: > Can you remove the "content/browser/compositor" DEPS entry again ...
4 years, 9 months ago (2016-03-24 18:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830293003/20001
4 years, 9 months ago (2016-03-24 21:45:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 21:51:08 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 21:52:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae96391ad67ebb128d0e0082bdd9633989fd370b
Cr-Commit-Position: refs/heads/master@{#383156}

Powered by Google App Engine
This is Rietveld 408576698