Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: ui/app_list/shower/app_list_shower_impl.h

Issue 1830293002: AppListController refactoring part 1: AppListShower implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing target names in .isolate. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/shower/app_list_shower_export.h ('k') | ui/app_list/shower/app_list_shower_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/shower/app_list_shower_impl.h
diff --git a/ash/wm/app_list_controller.h b/ui/app_list/shower/app_list_shower_impl.h
similarity index 39%
copy from ash/wm/app_list_controller.h
copy to ui/app_list/shower/app_list_shower_impl.h
index 1f3114c37d4858c4bfda875bd5e4fb9696d9a4d5..85cce8567e34a7176f25982daa75d289a45ad98c 100644
--- a/ash/wm/app_list_controller.h
+++ b/ui/app_list/shower/app_list_shower_impl.h
@@ -1,83 +1,65 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ASH_WM_APP_LIST_CONTROLLER_H_
-#define ASH_WM_APP_LIST_CONTROLLER_H_
+#ifndef UI_APP_LIST_SHOWER_APP_LIST_SHOWER_IMPL_H_
+#define UI_APP_LIST_SHOWER_APP_LIST_SHOWER_IMPL_H_
-#include "ash/shelf/shelf_icon_observer.h"
-#include "ash/shell_observer.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "ui/app_list/pagination_model_observer.h"
+#include "ui/app_list/shower/app_list_shower.h"
+#include "ui/app_list/shower/app_list_shower_delegate.h"
#include "ui/aura/client/focus_change_observer.h"
#include "ui/aura/window_observer.h"
#include "ui/compositor/layer_animation_observer.h"
-#include "ui/events/event_handler.h"
#include "ui/gfx/geometry/rect.h"
-#include "ui/keyboard/keyboard_controller_observer.h"
#include "ui/views/widget/widget_observer.h"
namespace app_list {
-class ApplicationDragAndDropHost;
class AppListView;
-}
-
-namespace ui {
-class LocatedEvent;
-}
+class AppListViewDelegate;
+class AppListShowerDelegateFactory;
-namespace ash {
namespace test {
-class AppListControllerTestApi;
+class AppListShowerImplTestApi;
}
-// AppListController is a controller that manages app list UI for shell.
-// It creates AppListView and schedules showing/hiding animation.
-// While the UI is visible, it monitors things such as app list widget's
-// activation state and desktop mouse click to auto dismiss the UI.
-class AppListController : public ui::EventHandler,
- public aura::client::FocusChangeObserver,
- public aura::WindowObserver,
- public ui::ImplicitAnimationObserver,
- public views::WidgetObserver,
- public keyboard::KeyboardControllerObserver,
- public ShellObserver,
- public ShelfIconObserver,
- public app_list::PaginationModelObserver {
+class AppListShowerImplTest;
+class AppListViewDelegate;
+
+// Manages app list UI. Creates AppListView and schedules showing/hiding
+// animation. While the UI is visible, it monitors things such as app list
+// activation state to auto dismiss the UI. Delegates the responsibility
+// for laying out the app list UI to ash::AppListLayoutDelegate.
+class APP_LIST_SHOWER_EXPORT AppListShowerImpl
+ : public AppListShower,
+ public aura::client::FocusChangeObserver,
+ public aura::WindowObserver,
+ public ui::ImplicitAnimationObserver,
+ public views::WidgetObserver,
+ public PaginationModelObserver {
public:
- AppListController();
- ~AppListController() override;
-
- // Show/hide app list window. The |window| is used to deterime in
- // which display (in which the |window| exists) the app list should
- // be shown.
- void Show(aura::Window* window);
- void Dismiss();
-
- // Whether app list window is visible (shown or being shown).
- bool IsVisible() const;
-
- // Returns target visibility. This differs from IsVisible() if an animation
- // is ongoing.
- bool GetTargetVisibility() const { return is_visible_; }
+ explicit AppListShowerImpl(AppListShowerDelegateFactory* factory);
+ ~AppListShowerImpl() override;
// Returns app list window or NULL if it is not visible.
aura::Window* GetWindow();
// Returns app list view if one exists, or NULL otherwise.
- app_list::AppListView* GetView() { return view_; }
+ AppListView* GetView() { return view_; }
- private:
- friend class test::AppListControllerTestApi;
+ // AppListShower:
+ void Show(aura::Window* window) override;
+ void Dismiss() override;
+ bool IsVisible() const override;
+ bool GetTargetVisibility() const override;
- // If |drag_and_drop_host| is not NULL it will be called upon drag and drop
- // operations outside the application list.
- void SetDragAndDropHostOfCurrentAppList(
- app_list::ApplicationDragAndDropHost* drag_and_drop_host);
+ private:
+ friend class test::AppListShowerImplTestApi;
// Sets the app list view and attempts to show it.
- void SetView(app_list::AppListView* view);
+ void SetView(AppListView* view);
// Forgets the view.
void ResetView();
@@ -85,15 +67,6 @@ class AppListController : public ui::EventHandler,
// Starts show/hide animation.
void ScheduleAnimation();
- void ProcessLocatedEvent(ui::LocatedEvent* event);
-
- // Makes app list bubble update its bounds.
- void UpdateBounds();
-
- // ui::EventHandler overrides:
- void OnMouseEvent(ui::MouseEvent* event) override;
- void OnGestureEvent(ui::GestureEvent* event) override;
-
// aura::client::FocusChangeObserver overrides:
void OnWindowFocused(aura::Window* gained_focus,
aura::Window* lost_focus) override;
@@ -109,45 +82,37 @@ class AppListController : public ui::EventHandler,
// views::WidgetObserver overrides:
void OnWidgetDestroying(views::Widget* widget) override;
- // KeyboardControllerObserver overrides:
- void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;
-
- // ShellObserver overrides:
- void OnShelfAlignmentChanged(aura::Window* root_window) override;
- void OnMaximizeModeStarted() override;
- void OnMaximizeModeEnded() override;
-
- // ShelfIconObserver overrides:
- void OnShelfIconPositionsChanged() override;
-
- // app_list::PaginationModelObserver overrides:
+ // PaginationModelObserver overrides:
void TotalPagesChanged() override;
void SelectedPageChanged(int old_selected, int new_selected) override;
void TransitionStarted() override;
void TransitionChanged() override;
- // Whether we should show or hide app list widget.
- bool is_visible_;
+ // Not owned
+ AppListShowerDelegateFactory* const factory_;
- // Whether the app list should remain centered.
- bool is_centered_;
+ // Responsible for laying out the app list UI.
+ scoped_ptr<AppListShowerDelegate> shower_delegate_;
+
+ // Whether we should show or hide app list widget.
+ bool is_visible_ = false;
// The AppListView this class manages, owned by its widget.
- app_list::AppListView* view_;
+ AppListView* view_ = nullptr;
// The current page of the AppsGridView of |view_|. This is stored outside of
// the view's PaginationModel, so that it persists when the view is destroyed.
- int current_apps_page_;
+ int current_apps_page_ = -1;
// Cached bounds of |view_| for snapping back animation after over-scroll.
gfx::Rect view_bounds_;
// Whether should schedule snap back animation.
- bool should_snap_back_;
+ bool should_snap_back_ = false;
- DISALLOW_COPY_AND_ASSIGN(AppListController);
+ DISALLOW_COPY_AND_ASSIGN(AppListShowerImpl);
};
-} // namespace ash
+} // namespace app_list
-#endif // ASH_WM_APP_LIST_CONTROLLER_H_
+#endif // UI_APP_LIST_SHOWER_APP_LIST_SHOWER_IMPL_H_
« no previous file with comments | « ui/app_list/shower/app_list_shower_export.h ('k') | ui/app_list/shower/app_list_shower_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698