Chromium Code Reviews Chromium Code Reviews
Issue 1830293002:
AppListController refactoring part 1: AppListShower implementation. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # This file is used by the GN meta build system to find the root of the source | 1 # This file is used by the GN meta build system to find the root of the source |
| 2 # tree and to set startup options. For documentation on the values set in this | 2 # tree and to set startup options. For documentation on the values set in this |
| 3 # file, run "gn help dotfile" at the command line. | 3 # file, run "gn help dotfile" at the command line. |
| 4 | 4 |
| 5 # The location of the build configuration file. | 5 # The location of the build configuration file. |
| 6 buildconfig = "//build/config/BUILDCONFIG.gn" | 6 buildconfig = "//build/config/BUILDCONFIG.gn" |
| 7 | 7 |
| 8 # The secondary source root is a parallel directory tree where | 8 # The secondary source root is a parallel directory tree where |
| 9 # GN build files are placed when they can not be placed directly | 9 # GN build files are placed when they can not be placed directly |
| 10 # in the source tree, e.g. for third party source trees. | 10 # in the source tree, e.g. for third party source trees. |
| (...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 96 "//third_party/kasko/*", | 96 "//third_party/kasko/*", |
| 97 "//third_party/libaddressinput/*", | 97 "//third_party/libaddressinput/*", |
| 98 "//third_party/libphonenumber/*", | 98 "//third_party/libphonenumber/*", |
| 99 "//third_party/WebKit/Source/*", | 99 "//third_party/WebKit/Source/*", |
| 100 "//tools/*", | 100 "//tools/*", |
| 101 | 101 |
| 102 #"//ui/*", # Work left on Chromeos w/ use_ozone. Some parts of UI that work: | 102 #"//ui/*", # Work left on Chromeos w/ use_ozone. Some parts of UI that work: |
| 103 "//ui/accessibility/*", | 103 "//ui/accessibility/*", |
| 104 "//ui/android/*", | 104 "//ui/android/*", |
| 105 "//ui/app_list/*", | 105 "//ui/app_list/*", |
| 106 "//ui/app_list/shower/*", | |
|
xiyuan
2016/04/04 17:09:30
Would this be included in "//ui/app_list/*" line a
mfomitchev
2016/04/04 18:59:06
Yup, you are right, this is not needed. Removed.
| |
| 106 "//ui/aura/*", | 107 "//ui/aura/*", |
| 107 "//ui/aura_extra/*", | 108 "//ui/aura_extra/*", |
| 108 "//ui/base/*", | 109 "//ui/base/*", |
| 109 "//ui/chromeos/*", | 110 "//ui/chromeos/*", |
| 110 "//ui/compositor/*", | 111 "//ui/compositor/*", |
| 111 "//ui/display/*", | 112 "//ui/display/*", |
| 112 "//ui/events:events", # Specifically avoid //ui/events/ozone | 113 "//ui/events:events", # Specifically avoid //ui/events/ozone |
| 113 "//ui/events:events_base", | 114 "//ui/events:events_base", |
| 114 "//ui/events:events_unittests", | 115 "//ui/events:events_unittests", |
| 115 "//ui/file_manager/*", | 116 "//ui/file_manager/*", |
| (...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 243 "//tools/gn/format_test_data/055.golden", | 244 "//tools/gn/format_test_data/055.golden", |
| 244 "//tools/gn/function_exec_script.cc", | 245 "//tools/gn/function_exec_script.cc", |
| 245 "//tools/gn/gn.gyp", | 246 "//tools/gn/gn.gyp", |
| 246 "//tools/gn/input_conversion.cc", | 247 "//tools/gn/input_conversion.cc", |
| 247 "//tools/gn/misc/emacs/gn.el", | 248 "//tools/gn/misc/emacs/gn.el", |
| 248 "//tools/gn/misc/vim/syntax/gn.vim", | 249 "//tools/gn/misc/vim/syntax/gn.vim", |
| 249 "//tools/gn/setup.cc", | 250 "//tools/gn/setup.cc", |
| 250 "//ui/accessibility/BUILD.gn", | 251 "//ui/accessibility/BUILD.gn", |
| 251 "//ui/views/BUILD.gn", | 252 "//ui/views/BUILD.gn", |
| 252 ] | 253 ] |
| OLD | NEW |
