Issue 183027: A quick fix for Issue 20161...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183027: A quick fix for Issue 20161... (Closed)

Created:
11 years, 3 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Issue 20161 My r22262 changed the code that handles keyboard events dramatically, and this prevent TestShell from inputting characters. This change just sends Char events to emulate keyboard events. (We need to implement the NSTextInput protocol for TestShell, though.) BUG=20161 "Keyboard doesn't work in Mac TestShell" TEST=Run TestShell on Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25303

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	webkit/tools/test_shell/mac/webwidget_host.mm	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

11 years, 3 months ago (2009-09-02 13:48:47 UTC) #2

LG

http://codereview.chromium.org/183027/diff/2001/2002
File webkit/tools/test_shell/mac/webwidget_host.mm (right):

http://codereview.chromium.org/183027/diff/2001/2002#newcode262
Line 262: // TODO(hbono): Bug 20852: implement the NSTextInput protocol and
remove
Usually we use an "http://crbug.com/10852" style comment to get a clickable
link.

Expand Messages | Collapse Messages

Issue 183027: A quick fix for Issue 20161... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages