Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183023016: Check IP address size when deserializing IPEndPoint. (Closed)

Created:
6 years, 9 months ago by Tom Sepez
Modified:
6 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, aarya
Visibility:
Public.

Description

Check IP address size when deserializing IPEndPoint. Failure to do so leads to a CHECK() in the browser under the IPC fuzzing tests, which generates a lot of false positives. Instead, we can invert the situation and blame the renderer. BUG=349572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255686

Patch Set 1 #

Patch Set 2 : Also allow empty IPEndPoints across the wire. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/public/common/common_param_traits.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Tom Sepez
eroman, jam - please review.
6 years, 9 months ago (2014-03-05 20:30:08 UTC) #1
jam
On 2014/03/05 20:30:08, Tom Sepez wrote: > eroman, jam - please review. Tom: since you're ...
6 years, 9 months ago (2014-03-05 22:33:21 UTC) #2
eroman
lgtm
6 years, 9 months ago (2014-03-06 04:39:36 UTC) #3
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 9 months ago (2014-03-06 19:05:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/183023016/20001
6 years, 9 months ago (2014-03-06 19:09:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:20:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 19:20:18 UTC) #7
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 9 months ago (2014-03-06 20:21:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/183023016/20001
6 years, 9 months ago (2014-03-06 20:59:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/183023016/20001
6 years, 9 months ago (2014-03-06 21:53:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 23:31:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 23:31:22 UTC) #12
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 9 months ago (2014-03-07 17:39:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/183023016/20001
6 years, 9 months ago (2014-03-07 17:40:08 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 19:42:11 UTC) #15
Message was sent while issue was closed. 
Change committed as 255686

Powered by Google App Engine
This is Rietveld 408576698