Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 183023014: Give PictureTest more verbose error messages. (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Give PictureTest more verbose error messages. Motivation: On an odd build system I'm testing, we're triggering these errors. More verbose test output will help me diagnose the errors. Committed: http://code.google.com/p/skia/source/detail?r=13678

Patch Set 1 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -33 lines) Patch
M tests/PictureTest.cpp View 6 chunks +47 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
PTAL
6 years, 9 months ago (2014-03-05 19:19:31 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-05 19:24:40 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-05 19:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/183023014/10001
6 years, 9 months ago (2014-03-05 19:57:50 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 20:59:55 UTC) #5
Message was sent while issue was closed.
Change committed as 13678

Powered by Google App Engine
This is Rietveld 408576698