Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 183021: Migrate cookies for the time epoch change. (Closed)

Created:
11 years, 3 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Migrate cookies for the time epoch change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25040

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M chrome/common/net/cookie_monster_sqlite.cc View 1 2 2 chunks +42 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
brettw
I did not see something that would cause your cookies to all get deleted more ...
11 years, 3 months ago (2009-09-01 00:00:53 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/183021/diff/4/3001 File chrome/common/net/cookie_monster_sqlite.cc (right): http://codereview.chromium.org/183021/diff/4/3001#newcode279 Line 279: static const int kCompatibleVersionNumber = 3; Can ...
11 years, 3 months ago (2009-09-01 00:04:14 UTC) #2
Dean McNamee
11 years, 3 months ago (2009-09-02 16:01:09 UTC) #3
I didn't mind the plan of just dropping cookies.  If the expire jumps
back in time, they will just be garbage collected eventually.

On Tue, Sep 1, 2009 at 2:04 AM, <evan@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/183021/diff/4/3001
> File chrome/common/net/cookie_monster_sqlite.cc (right):
>
> http://codereview.chromium.org/183021/diff/4/3001#newcode279
> Line 279: static const int kCompatibleVersionNumber =3D 3;
> Can you doc this too? =A0(I checked the code and it seems correct to leav=
e
> it at 3, but it'd be nice if the comments made it so I didn't need to
> check.)
>
> http://codereview.chromium.org/183021
>

Powered by Google App Engine
This is Rietveld 408576698