Issue 18302005: Fixing mapping of attribute maps on FireFox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18302005: Fixing mapping of attribute maps on FireFox. (Closed)

Created:
7 years, 5 months ago by blois

Modified:
7 years, 5 months ago

Reviewers:
sra1, Jennifer Messerly

CC:
reviews_dartlang.org, Jennifer Messerly

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing mapping of attribute maps on FireFox. Not sure when/why this broke (most likely FF change), but one of the MDV tests started failing because of it: http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ff-win7-1-2/builds/5798/steps/dart2js%20tests/logs/stdio Closest thing I can find in reference to this type refers to it going away in WebKit: http://trac.webkit.org/changeset/42107 BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=24870

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/dom/scripts/generator.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 5 months ago (2013-07-10 00:25:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24870 (presubmit successful).