more bookmark tests, plus fix a couple of API bugs

more bookmark tests, plus fix a couple of API bugs

BUG=19099, 17288
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25036

[Erik does not do reviews, 2009-08-31 23:26:53]

There's more to do here, but since the branch is being cut tomorrow, and this
fixes a couple of API bugs, I thought I'd try to get this in as-is.

[rafaelw, 2009-09-01 02:33:12]

lgtm?

http://codereview.chromium.org/183020/diff/1/9
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/183020/diff/1/9#newcode14
Line 14: var node1 = {parentId:"1", title:"Foo bar baz",
url:"http://www.example.com/hello"};
80 cols. multiple places in this file

http://codereview.chromium.org/183020/diff/1/9#newcode141
Line 141: var other = expected[0].children[1];
this is a little hard to follow. can you maybe add a comment which summarizes
the expected pre & post state of the nodes?

http://codereview.chromium.org/183020/diff/1/9#newcode145
Line 145: //chrome.test.assertTrue(results.parentId == other.id);
did you intentionally leave these result tests commented out?

[rafaelw, 2009-09-01 02:34:12]

sorry. that's "lgtm.", not "lgtm?"

[Erik does not do reviews, 2009-09-01 15:33:12]

http://codereview.chromium.org/183020/diff/1/9
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/183020/diff/1/9#newcode14
Line 14: var node1 = {parentId:"1", title:"Foo bar baz",
url:"http://www.example.com/hello"};
On 2009/09/01 02:33:12, rafaelw wrote:
> 80 cols. multiple places in this file

fixed

http://codereview.chromium.org/183020/diff/1/9#newcode141
Line 141: var other = expected[0].children[1];
On 2009/09/01 02:33:12, rafaelw wrote:
> this is a little hard to follow. can you maybe add a comment which summarizes
> the expected pre & post state of the nodes?

ok

http://codereview.chromium.org/183020/diff/1/9#newcode145
Line 145: //chrome.test.assertTrue(results.parentId == other.id);
On 2009/09/01 02:33:12, rafaelw wrote:
> did you intentionally leave these result tests commented out?

Yeah, this wasn't working because move wasn't returning the node in the
callback.  I had fixed that in the C++ code, but hadn't updated the test to
match.  Fixed.