Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2119)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 183013013: Pre-cache PLY lex table and use optimized mode (5% build time improvement) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix order Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/blink_idl_parser.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index cb9fcd977aec4c01bc26bcac408e2286d9a96c46..f6427214d481ed2ec3fdec70051ce7be42850d47 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -214,10 +214,11 @@ class BindingsTests(object):
file_pairs = [(os.path.join(reference_directory, output_file),
os.path.join(self.output_directory, output_file))
for output_file in os.listdir(self.output_directory)
- # Skip cache
- if not output_file.endswith(('.pickle', # PLY yacc
- '.cache', # Jinja
- ))]
+ # Skip caches
+ if not (output_file in ('lextab.py', # PLY lex
+ 'lextab.pyc',
+ 'parsetab.pickle') or # PLY yacc
+ output_file.endswith('.cache'))] # Jinja
return all([self.identical_file(reference_filename, output_filename)
for (reference_filename, output_filename) in file_pairs])
« no previous file with comments | « Source/bindings/scripts/blink_idl_parser.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698