Source/bindings/scripts/blink_idl_parser.py - Issue 183013013: Pre-cache PLY lex table and use optimized mode (5% build time improvement)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/blink_idl_parser.py

Issue 183013013: Pre-cache PLY lex table and use optimized mode (5% build time improvement) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix import path handling Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/blink_idl_parser.py

diff --git a/Source/bindings/scripts/blink_idl_parser.py b/Source/bindings/scripts/blink_idl_parser.py

index 30d625bad11ad0c38b98f6bf3f43c35c52999a96..adf2f04cf12521d9db4f8f6ec778795b472e1a35 100644

--- a/Source/bindings/scripts/blink_idl_parser.py

+++ b/Source/bindings/scripts/blink_idl_parser.py

@@ -420,7 +420,9 @@ class BlinkIDLParser(IDLParser):

if outputdir:

picklefile = picklefile or os.path.join(outputdir, 'parsetab.pickle')

- lexer = lexer or BlinkIDLLexer()

+ lexer = lexer or BlinkIDLLexer(debug=debug,

+ outputdir=outputdir,

+ optimize=optimize)

self.lexer = lexer

self.tokens = lexer.KnownTokens()

# Using SLR (instead of LALR) generates the table faster,