Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: Source/bindings/generated_bindings.gyp

Issue 183013013: Pre-cache PLY lex table and use optimized mode (5% build time improvement) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix import path handling Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/generated_bindings.gyp
diff --git a/Source/bindings/generated_bindings.gyp b/Source/bindings/generated_bindings.gyp
index ad11941461aa17584cbf90f1ddcc5dc4c491a7d5..bac2c353fbfcb36a62217689bf3944a54dfa53ef 100644
--- a/Source/bindings/generated_bindings.gyp
+++ b/Source/bindings/generated_bindings.gyp
@@ -284,11 +284,11 @@
},
################################################################################
{
- # A separate pre-caching step is *not required* to use parse table caching
- # in PLY, as the cache is concurrency-safe.
+ # A separate pre-caching step is *not required* to use lex/parse table
+ # caching in PLY, as the caches are concurrency-safe.
# However, pre-caching ensures that all compiler processes use the cached
- # file (hence maximizing speed), instead of early processes building the
- # table themselves (as it's not yet been written by the time they start).
+ # files (hence maximizing speed), instead of early processes building the
+ # tables themselves (as they've not yet been written when they start).
'target_name': 'cached_yacc_tables',
'type': 'none',
'actions': [{
@@ -297,6 +297,7 @@
'<@(idl_lexer_parser_files)',
],
'outputs': [
+ '<(bindings_output_dir)/lextab.py',
'<(bindings_output_dir)/parsetab.pickle',
],
'action': [
@@ -304,7 +305,7 @@
'scripts/blink_idl_parser.py',
'<(bindings_output_dir)',
],
- 'message': 'Caching PLY yacc parse tables',
+ 'message': 'Caching PLY lex & yacc lex/parse tables',
}],
},
################################################################################
@@ -356,6 +357,7 @@
'inputs': [
'<@(idl_lexer_parser_files)', # to be explicit (covered by parsetab)
'<@(idl_compiler_files)',
+ '<(bindings_output_dir)/lextab.py',
'<(bindings_output_dir)/parsetab.pickle',
'<(bindings_output_dir)/cached_jinja_templates.stamp',
'IDLExtendedAttributes.txt',
« no previous file with comments | « no previous file | Source/bindings/scripts/blink_idl_lexer.py » ('j') | Source/bindings/scripts/blink_idl_lexer.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698