Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: content/browser/renderer_host/input/touch_event_queue.h

Issue 183013010: Don't send touchcancel on touch scroll start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a couple tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/touch_event_queue.h
diff --git a/content/browser/renderer_host/input/touch_event_queue.h b/content/browser/renderer_host/input/touch_event_queue.h
index 6c50c329e85938dbeb53b6725ef738fad1fe481f..e43079a346526a270b31d01159604069a1594068 100644
--- a/content/browser/renderer_host/input/touch_event_queue.h
+++ b/content/browser/renderer_host/input/touch_event_queue.h
@@ -37,8 +37,8 @@ class CONTENT_EXPORT TouchEventQueueClient {
class CONTENT_EXPORT TouchEventQueue {
public:
// Different ways of dealing with touch events during scrolling.
- // TODO(rbyers): Remove (or otherwise update) this once results of
- // experiments are complete. http://crbug.com/328503
+ // TODO(rbyers): Remove this once we're confident that touch move absorption
+ // is OK. http://crbug.com/350430
enum TouchScrollingMode {
// Send a touchcancel on scroll start and no further touch events for the
// duration of the scroll. Chrome Android's traditional behavior.
@@ -50,9 +50,9 @@ class CONTENT_EXPORT TouchEventQueue {
// Like sync, except that consumed scroll events cause subsequent touchmove
// events to be suppressed. Unconsumed scroll events return touchmove
// events to being dispatched synchronously (so scrolling may be hijacked
- // when a scroll limit is reached, and later resumed).
+ // when a scroll limit is reached, and later resumed). http://goo.gl/RShsdN
TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE,
- TOUCH_SCROLLING_MODE_DEFAULT = TOUCH_SCROLLING_MODE_TOUCHCANCEL
+ TOUCH_SCROLLING_MODE_DEFAULT = TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE
};
// The |client| must outlive the TouchEventQueue. If

Powered by Google App Engine
This is Rietveld 408576698