Issue 183013005: Remove textDirection parameter from min/maxLogicalWidth

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183013005: Remove textDirection parameter from min/maxLogicalWidth (Closed)

Created:
6 years, 9 months ago by eae

Modified:
6 years, 9 months ago

Reviewers:
dglazkov

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove textDirection parameter from min/maxLogicalWidth Remove unnecessary textDirection parameter from the min/maxLogicalWidth methods and computePreferredLogicalWidths and instead use the resolved text directionality. BUG=333004 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168449

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+28 lines, -21 lines)			Patch
Source/core/rendering/RenderRubyRun.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
Source/core/rendering/RenderText.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
Source/core/rendering/RenderText.cpp	View	6 chunks	+22 lines, -14 lines	0 comments	Download

Total messages: 7 (0 generated)

dglazkov

lgtm. rietveld chunk error'd on the latest upload, so I reviewed the patch as raw ...

6 years, 9 months ago (2014-03-04 17:33:56 UTC) #3

eae

On 2014/03/04 17:33:56, Dimitri Glazkov wrote: > lgtm. > > rietveld chunk error'd on the ...

6 years, 9 months ago (2014-03-04 17:34:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/183013005/1

6 years, 9 months ago (2014-03-04 17:34:43 UTC) #6

Message was sent while issue was closed.

Change committed as 168449