Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1830113004: Temporarily disable remoting_client_plugin_newlib on win in GN builds. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable remoting_client_plugin_newlib on win in GN builds. Trying to build this causes out-of-memory issues with the pnacl linker, likely because it's a 32-bit tool and the GN builds are using source_sets instead of static_libraries, causing us to link in a lot more code before it can get gc'ed. Disabling temporarily until I have cycles to look at this, because it keeps `gn_all` from building. R=brucedawson@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org BUG=584516 Committed: https://crrev.com/fad8e464eda52dcd079f58a6fc4ccaee1955bcd3 Cr-Commit-Position: refs/heads/master@{#383191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M remoting/webapp/build_template.gni View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Roland McGrath
lgtm
4 years, 9 months ago (2016-03-24 22:33:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830113004/1
4 years, 9 months ago (2016-03-24 22:58:40 UTC) #4
Sergey Ulanov
lgtm
4 years, 9 months ago (2016-03-24 22:58:58 UTC) #5
brucedawson
Thank you, and lgtm.
4 years, 9 months ago (2016-03-24 23:19:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 23:43:48 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:45:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fad8e464eda52dcd079f58a6fc4ccaee1955bcd3
Cr-Commit-Position: refs/heads/master@{#383191}

Powered by Google App Engine
This is Rietveld 408576698