Introduce DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro

Introduce DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro

Split DEFINE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro into separate
DECLARE and DEFINE macros to reduce the number of header includes in
SVG.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153530

[do-not-use, 2013-07-03 15:59:55]

https://codereview.chromium.org/18301003/diff/1/Source/core/dom/EventTarget.h
File Source/core/dom/EventTarget.h (right):

https://codereview.chromium.org/18301003/diff/1/Source/core/dom/EventTarget.h...
Source/core/dom/EventTarget.h:168: #define
DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER(recipient, attribute) \
Note the FIXME at line 146 regarding this:
// FIXME: These macros should be split into separate DEFINE and DECLARE
// macros to avoid causing so many header includes.

[Stephen Chennney, 2013-07-03 17:10:35]

Wow. At first I thought this wasn't worth the effort, but then I looked for
SVGElementInstance.h and found 61 include, not many of which also include
SVGElement.h.

LGTM with minor nits to fix before commit.

https://codereview.chromium.org/18301003/diff/1/Source/core/dom/EventTarget.h
File Source/core/dom/EventTarget.h (right):

https://codereview.chromium.org/18301003/diff/1/Source/core/dom/EventTarget.h...
Source/core/dom/EventTarget.h:170: void
setOn##attribute(PassRefPtr<EventListener> listener, DOMWrapperWorld*
isolatedWorld); \
Nit, no need for the \.

https://codereview.chromium.org/18301003/diff/1/Source/core/dom/EventTarget.h...
Source/core/dom/EventTarget.h:174: void
type::setOn##attribute(PassRefPtr<EventListener> listener, DOMWrapperWorld*
isolatedWorld) { if (recipient)
recipient->setAttributeEventListener(eventNames().attribute##Event, listener,
isolatedWorld); } \
Same.

[do-not-use, 2013-07-03 17:15:13]

On 2013/07/03 17:10:35, Stephen Chenney wrote:
> Wow. At first I thought this wasn't worth the effort, but then I looked for
> SVGElementInstance.h and found 61 include, not many of which also include
> SVGElement.h.

So you know, I'm actually working on merging SVGStyledElement and SVGElement and
this patch is a pre-requirement. When merging SVGStyledElement into SVGElement,
I end up with a circular header include due to adding ANIMATED_PROPERTIES macros
SVGElement.h and requiring new includes that themselves depends on SVGElement.h.

[commit-bot: I haz the power, 2013-07-03 17:18:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18301003/8001

[commit-bot: I haz the power, 2013-07-03 18:14:25]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-03 18:38:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18301003/8001

[krit, 2013-07-03 18:52:03]

On 2013/07/03 17:15:13, Christophe Dumez wrote:
> On 2013/07/03 17:10:35, Stephen Chenney wrote:
> > Wow. At first I thought this wasn't worth the effort, but then I looked for
> > SVGElementInstance.h and found 61 include, not many of which also include
> > SVGElement.h.
> 
> So you know, I'm actually working on merging SVGStyledElement and SVGElement
and
> this patch is a pre-requirement. When merging SVGStyledElement into
SVGElement,
> I end up with a circular header include due to adding ANIMATED_PROPERTIES
macros
> SVGElement.h and requiring new includes that themselves depends on
SVGElement.h.

Yes, that is why pdr and I stopped with simplifying the inheritance structure in
WebKit at this point. Great progress!

[commit-bot: I haz the power, 2013-07-03 19:43:51]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-03 19:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18301003/8001

[commit-bot: I haz the power, 2013-07-03 22:03:05]

Change committed as 153530