Issue 183005: Remove LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html since...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183005: Remove LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html since... (Closed)

Created:
11 years, 3 months ago by Julie Parent

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html since I fixed the test upstream in http://trac.webkit.org/changeset/47873. TEST=none, won't commit until I see this passing but expected to fail on bots. BUG=9916

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years, 3 months ago (2009-08-28 21:25:55 UTC) #2

LGTM

On Fri, Aug 28, 2009 at 2:20 PM, <jparent@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Remove LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html
> since I fixed the test upstream in
> http://trac.webkit.org/changeset/47873.
>
> TEST=none, won't commit until I see this passing but expected to fail on
> bots.
> BUG=9916
>
> Please review this at http://codereview.chromium.org/183005
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24794)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -2155,7 +2155,6 @@
>
>  // Failed in WebKit merge 42287:42324
>  BUG9916 WIN LINUX : LayoutTests/css2.1/t0803-c5502-mrgn-r-02-c.html = FAIL
> -BUG9916 : LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html
> = FAIL
>
>  // New tests or failures from WebKit merge 42324:42364. Re-baselined on
>  // Windows. Probably just need the same on other platforms.
>
>
>

Expand Messages | Collapse Messages