Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 183003012: Rebaseline expectations for fast/dom/Window/property-access-on-cached* on Mac (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
CC:
blink-reviews, vsevik
Visibility:
Public.

Description

Rebaseline expectations for fast/dom/Window/property-access-on-cached* on Mac TBR=dongseong.hwang@chromium.org BUG=348549 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168380

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
apavlov
Committed patchset #1 manually as r168380 (presubmit successful).
6 years, 9 months ago (2014-03-04 11:41:38 UTC) #1
Erik Corry
Why is this change Mac-only?
6 years, 9 months ago (2014-03-10 10:47:08 UTC) #2
apavlov
On 2014/03/10 10:47:08, Erik Corry wrote: > Why is this change Mac-only? Guess because only ...
6 years, 9 months ago (2014-03-10 12:15:19 UTC) #3
Erik Corry
I ask because I'm seeing the same difference on Linux. I'm trying to understand why ...
6 years, 9 months ago (2014-03-10 12:16:16 UTC) #4
apavlov
On 2014/03/10 12:16:16, Erik Corry wrote: > I ask because I'm seeing the same difference ...
6 years, 9 months ago (2014-03-10 12:30:33 UTC) #5
Erik Corry
I'm not seeing the flaky error, just the extra property like in this change.
6 years, 9 months ago (2014-03-10 12:31:15 UTC) #6
apavlov
On 2014/03/10 12:31:15, Erik Corry wrote: > I'm not seeing the flaky error, just the ...
6 years, 9 months ago (2014-03-10 12:33:07 UTC) #7
dshwang
6 years, 9 months ago (2014-03-14 20:30:13 UTC) #8
Message was sent while issue was closed.
On 2014/03/10 12:33:07, apavlov wrote:
> On 2014/03/10 12:31:15, Erik Corry wrote:
> > I'm not seeing the flaky error, just the extra property like in this change.
> 
> That's really strange. And, as far as I understand, this is not related to the
> original patch.

sorry for delayed reply, because I usually use dongseong.hwang@intel.com
btw, I can not imagine how I was involved in fast/dom/Window.. as I remember, I
did not change any dom code...

Powered by Google App Engine
This is Rietveld 408576698